Bug 51895 - Irritating tilde (~) character at beginning of German buttons captions, introduced in 3.6b3
Summary: Irritating tilde (~) character at beginning of German buttons captions, intro...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Localization (show other bugs)
Version:
(earliest affected)
3.6.0.0.beta3
Hardware: Other macOS (All)
: medium minor
Assignee: Andras Timar
URL:
Whiteboard:
Keywords: regression
: 51942 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-07-09 08:01 UTC by Roman Eisele
Modified: 2012-11-16 12:02 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Global application "Options" dialog in 3.6b3 with German UI (76.81 KB, image/png)
2012-07-09 08:01 UTC, Roman Eisele
Details
Writer "Paragraph" dialog in 3.6b3 with German UI (82.41 KB, image/png)
2012-07-09 08:01 UTC, Roman Eisele
Details
Writer "Character" dialog in 3.6b3 with German UI (80.12 KB, image/png)
2012-07-09 08:02 UTC, Roman Eisele
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Eisele 2012-07-09 08:01:00 UTC
Created attachment 64002 [details]
Global application "Options" dialog in 3.6b3 with German UI

In LibreOffice 3.6 beta 3 for MacOS X (did not test Windows and Linux), if you install and select the German langpack, the caption of certain buttons in different dialog windows begins with a spurious '~', e.g. "~OK" and "~Abbrechen" instead of "OK" and "Abbrechen".

I can't test all LibreOffice dialogs, but at least all instances of "OK" and "Abbrechen" in the (application) Options dialog and in Writer's Paragraph and Character dialogs are concerned.

This problem is brand new, in beta 2 there was NO '~' at the beginning of these captions.

The problem is not present in the default (US English) locale; there the same buttons have the correct captions "OK" and "Cancel".

I will attach some screenshots showing the spurious '~'.

This is a minor issue, but nevertheless it needs attentions, because it makes LibreOffice look rather unprofessional and ugly.
Comment 1 Roman Eisele 2012-07-09 08:01:40 UTC
Created attachment 64003 [details]
Writer "Paragraph" dialog in 3.6b3 with German UI
Comment 2 Roman Eisele 2012-07-09 08:02:04 UTC
Created attachment 64004 [details]
Writer "Character" dialog in 3.6b3 with German UI
Comment 3 Roman Eisele 2012-07-09 08:09:09 UTC
Update:
Further research shows that almost all buttons with captions "OK" and "Cancel" (German: "OK" and "Abbrechen") in all components (Writer, Calc, Impress ...) of LibreOffice are affected -- almost all begin with the spurious tilde character. At the moment I can't find any other buttons with different captions which show the tilde. But given the fact that "OK" and "Cancel" are used in most dialog windows, it is still true that a good part of all LibreOffice buttons are affected by this glitch.
Comment 4 Roman Eisele 2012-07-09 08:13:51 UTC
@Andras Timar:
Hello Andras, could you please take a look at this localization issue? It is a minor problem, of course, but it makes LibreOffice 3.6 beta 3 look a bit strange and should be fixed before 3.6 goes final. I hope that it should be rather easy to fix this issue, because it must have been introduced between beta 2 and beta 3, which narrows down the commits to check.

Thank you very much in advance!
Comment 5 Andras Timar 2012-07-09 14:41:12 UTC
I fixed it in Pootle (not the first time by the way). 
It is in vcl, SV_BUTTONTEXT_CANCEL and SV_BUTTONTEXT_OK. Somehow the German team should make sure that they don't reintroduce the bug.
Comment 6 Roman Eisele 2012-07-10 07:46:30 UTC
(In reply to comment #5)
> I fixed it in Pootle (not the first time by the way).

Good news! Thank you very much!

> It is in vcl, SV_BUTTONTEXT_CANCEL and SV_BUTTONTEXT_OK. Somehow the German
> team should make sure that they don't reintroduce the bug.

Can I (as a QA volunteer) do anything to ensure this? Should I mail somebody about this issue (and whom)?
Comment 7 Andras Timar 2012-07-10 08:00:24 UTC
(In reply to comment #6)
> Can I (as a QA volunteer) do anything to ensure this? Should I mail somebody
> about this issue (and whom)?

You can try to find out who within the German community works on the files offline, who uploads them to Pootle. 

I'm also thinking of about an extra check, so when en-US message does not have ~ then localized message should not have one. There is a check in Pootle for ~, but it detects missing ~, too,  which is not a problem.
Comment 8 Rainer Bielefeld Retired 2012-07-10 13:06:01 UTC
*** Bug 51942 has been marked as a duplicate of this bug. ***
Comment 9 Jochen 2012-07-10 20:11:52 UTC
I´m a member of the German localisation team. We have discussed the problem and find out the reason. One of the German localisation team has inserted the mnemonics to improve the usability in Windows. It has been overlooked that in MAC a problem occurs.
Now we have deleted all mnemonics in "OK" and "Abbrechen".
Problem is detected and solved.

@Roman:
> Can I (as a QA volunteer) do anything to ensure this? Should I mail somebody
> about this issue (and whom)?
Yes: post Your suspicion of a localisaton problem additional in German discuss-ML (only a few word or post the link to bugzilla).

@Rainer:
I assume that I will inform you when a problem with German localisation occurs?!
Sometimes it works.
Comment 10 Roman Eisele 2012-07-11 08:05:42 UTC
(In reply to comment #9)
> > Can I (as a QA volunteer) do anything to ensure this? Should I mail somebody
> > about this issue (and whom)?
> Yes: post Your suspicion of a localisaton problem additional in German
> discuss-ML (only a few word or post the link to bugzilla).

Thanks!
Comment 11 Andras Timar 2012-07-11 08:16:21 UTC
(In reply to comment #9)
> I´m a member of the German localisation team. We have discussed the problem and
> find out the reason. One of the German localisation team has inserted the
> mnemonics to improve the usability in Windows. It has been overlooked that in
> MAC a problem occurs.
> Now we have deleted all mnemonics in "OK" and "Abbrechen".
> Problem is detected and solved.

OK is bound to Enter and Abbrechen is bound to Esc, so mnemonics seems to be useless in my opinion. Nevertheless, only OK and Cancel in vcl has this problem (BTW they are used the most). And not only on Mac, but everywhere, even on Windows.
Comment 12 Roman Eisele 2012-07-11 09:38:29 UTC
(In reply to comment #11)
> OK is bound to Enter and Abbrechen is bound to Esc, so mnemonics seems to be
> useless in my opinion.

That's it -- at least on MacOS and MacOS X, no application has ever defined any special shortcuts for these buttons, because they are always bound to the system's pre-defined keys (on MacOS, Enter/Return for "OK" and Escape/Command+. for "Abbrechen").
Comment 13 Graf von Roit zu Hoya 2012-11-16 09:37:49 UTC
Is there any mention to patch this in 3.5.7 (Linux) too? There is still the bug in the german UI. Unfortunately 3.6.x show's only questionmarks "???" instead of key modifiers (Ctrl, Alt).

Maybe a good time for a 3.5.7.r3?
Comment 14 Roman Eisele 2012-11-16 12:02:04 UTC
(In reply to comment #13)
> Is there any mention to patch this in 3.5.7 (Linux) too? There is still the
> bug in the german UI. Unfortunately 3.6.x show's only questionmarks "???"
> instead of key modifiers (Ctrl, Alt).

The present issue is about a bug which appears in LibreOffice for Mac OS X only. If you see something similar in 3.5.7 on Linux, this is very probably another issue -- namely bug 56281 - “German OK and Cancel buttons show ~”. Please see that bug report for details.

I hope you will be happy to hear that bug 56281 is already fixed (on all platforms). The only question is: when will this fix appear in the 3.5.x branch?


> Maybe a good time for a 3.5.7.r3?

AFAIF there will be no 3.5.7.3 -- it would be confusing to release another 3.5.7 variant after 3.5.7 has already been released as final.

But there are some chances that sooner or later there will be a 3.5.8 release, which would also include the fix for bug 56281 ...


Resetting the present bug report again to RESOLVED/FIXED. If further discussion about similar issues on Linux is necessary, please add comments to bug 56281 instead. Thank you very much