Bug Hunting Session
Bug 53855 - Properly detect GCC built-in atomic functions
Summary: Properly detect GCC built-in atomic functions
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:3.7.0
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-20 18:24 UTC by Jung-uk Kim
Modified: 2012-08-27 13:29 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Detect GCC built-in atomic functions, __sync_add_and_fetch() and __sync_sub_and_fetch(). (1.50 KB, patch)
2012-08-20 18:24 UTC, Jung-uk Kim
Details
Configure clucene properly. (6.77 KB, patch)
2012-08-20 18:25 UTC, Jung-uk Kim
Details
Use the newly added HAVE_GCC_BUILTIN_ATOMIC for sal. (2.06 KB, patch)
2012-08-20 18:27 UTC, Jung-uk Kim
Details
Configure clucene properly. (7.23 KB, patch)
2012-08-20 18:38 UTC, Jung-uk Kim
Details
Detect GCC built-in atomic functions. (1.61 KB, patch)
2012-08-20 22:24 UTC, Jung-uk Kim
Details
Configure icu properly. (1.23 KB, patch)
2012-08-20 22:25 UTC, Jung-uk Kim
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jung-uk Kim 2012-08-20 18:24:28 UTC
Created attachment 65842 [details]
Detect GCC built-in atomic functions, __sync_add_and_fetch() and __sync_sub_and_fetch().

Currently, sal uses GCC built-in atomic functions based on GCC version.  Unfortunately, it is not always correct.  For example, FreeBSD has GCC 4.2.1 but it has __sync_add_and_fetch() and __sync_sub_and_fetch().  Also, Clang has these features.
Comment 1 Jung-uk Kim 2012-08-20 18:25:44 UTC
Created attachment 65843 [details]
Configure clucene properly.
Comment 2 Jung-uk Kim 2012-08-20 18:27:12 UTC
Created attachment 65844 [details]
Use the newly added HAVE_GCC_BUILTIN_ATOMIC for sal.
Comment 3 Jung-uk Kim 2012-08-20 18:38:42 UTC
Created attachment 65845 [details]
Configure clucene properly.
Comment 4 Jung-uk Kim 2012-08-20 22:24:24 UTC
Created attachment 65853 [details]
Detect GCC built-in atomic functions.

Added __sync_synchronize() and __sync_val_compare_and_swap().
Comment 5 Jung-uk Kim 2012-08-20 22:25:07 UTC
Created attachment 65854 [details]
Configure icu properly.
Comment 6 Not Assigned 2012-08-27 12:09:25 UTC
Jung-uk Kim committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0983231c8382234cc08124d1ce9a3e200dd0da0e

fdo#53855: Detect GCC built-in atomic functions
Comment 7 Not Assigned 2012-08-27 12:09:44 UTC
Jung-uk Kim committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1d6e13e13b36163c07fc6013c9c3da6fc553e697

fdo#53855: Use the newly added HAVE_GCC_BUILTIN_ATOMIC for sal
Comment 8 Not Assigned 2012-08-27 12:10:04 UTC
Jung-uk Kim committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8a55c4af62d90ff8518491a86a97bfe827591ece

fdo#53855: Use the newly added HAVE_GCC_BUILTIN_ATOMIC for clucene
Comment 9 Not Assigned 2012-08-27 12:10:22 UTC
Jung-uk Kim committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6e7baaaba85b0d6cd86e959f9af229a0d30c01f8

fdo#53855: Use the newly added HAVE_GCC_BUILTIN_ATOMIC for icu