Bug Hunting Session
Bug 53894 - Fix external ICU version check
Summary: Fix external ICU version check
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard: target:3.7.0
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-21 21:26 UTC by Jung-uk Kim
Modified: 2012-08-27 13:28 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Fix ICU version check. (875 bytes, patch)
2012-08-21 21:26 UTC, Jung-uk Kim
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jung-uk Kim 2012-08-21 21:26:19 UTC
Created attachment 65913 [details]
Fix ICU version check.

ICU changed the versioning scheme since 49 but it is not reflected in the configure script.

http://userguide.icu-project.org/design

- ICU Release Version Number (ICU 49 and later)

The first version number field contains the ICU release version number, for example 49. Each new version might contain new features, new locale data, and modified behavior. (See below for more information on ICU Binary Compatibility (§).)

The second field is 1 for the initial release (e.g., 49.1). The second and sometimes third fields are incremented for binary compatible maintenance releases.

    For maintenance releases for only either C or J, the third field is incremented (e.g., ICU4C 49.1.1).
    For shared updates for C & J, the second field is incremented to 2 and higher (e.g., ICU4C & ICU4J 49.2).

(The second field is 0 during development, with milestone numbers in the third field during that time. For example, 49.0.1 for 49 milestone 1.)

- ICU Release Version Number (ICU 1.4 to ICU 4.8)

In earlier releases, the first two version fields together indicated the ICU release, for example 4.8. The third field was 0 for the initial release, and 1 and higher for binary compatible (bug fixes only) maintenance releases (e.g., 4.8.1). The fourth field was used for updates specific to only one of Java, C++, or ICU-in-Eclipse.

The second version field was even for formal releases ("reference releases") (e.g., 1.6 or 4.8) and odd during their development (unreleased unstable snapshot versions; e.g., 4.7). During development, the third field contained the milestone number (e.g., 4.7.1 for 4.8 milestone 1). For very old ICU code, we published semi-formal “enhancement” releases with odd second-field numbers (e.g., 1.7).

Library filenames and some other internal uses already used a concatenation of the first two fields ("48" for 4.8).

Note this change is purely cosmetic because 49 is much bigger than 5, of course. ;-)
Comment 1 Not Assigned 2012-08-27 12:11:16 UTC
Jung-uk Kim committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c4ab4d3b2aa01f37bc38485fdee9ed59c68cb770

fdo#53894: Fix ICU version check