Bug 54741 - Keep focus on document when exiting fullscreen mode and dont focus on open non-modal Word count dialog
Summary: Keep focus on document when exiting fullscreen mode and dont focus on open no...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
3.5.7.2 release
Hardware: Other All
: lowest trivial
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsDevEval, topicUI
Depends on:
Blocks: Full-Screen-Mode Word-Count
  Show dependency tree / graph
 
Reported: 2012-09-10 17:14 UTC by leighman
Modified: 2024-10-28 03:12 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description leighman 2012-09-10 17:14:57 UTC 
Open word count dialog
Activate fullscreen
Deactivate fullscreen

Counts are lost

This does not seem to happen with any other dialogs.

Using 3.6.1 on Ubuntu quantal
Comment 1 Stefan Knorr (astron) 2012-11-25 00:09:36 UTC 
Can reproduce on master, 4.0 alpha1+, 64-bit Linux.

This (seemingly) happens because the Word Count window can be shared between multiple Writer windows. The word count window always counts for the last activated Writer window or the window that called it. Now, when Writer comes out of full-screen, the Word Count window somehow gains focus and loses its "attachment" to the Writer window.
Clicking on the Writer window again then lets gives the right word count again.

So, the bug actually seems to be that the window is not focused any more after it comes out of full-screen mode.
Comment 2 QA Administrators 2015-01-05 17:52:01 UTC Comment hidden (obsolete)
Comment 3 Buovjaga 2015-01-27 19:29:06 UTC 
Reproduced.

Win 7 Pro 64-bit Version: 4.5.0.0.alpha0+
Build ID: 784d069cc1d9f1d6e6a4e543a278376ab483d1eb
TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2015-01-25_23:07:36
Comment 4 Buovjaga 2015-01-27 19:29:54 UTC 
Let's lower severity to minor while we're at it.
Comment 5 QA Administrators 2016-02-21 08:36:53 UTC Comment hidden (obsolete)
Comment 6 Eltomito 2016-06-20 14:24:40 UTC 
This bug doesn't exist in LO 5.2.0.0 beta2, Linux version.
Comment 7 Buovjaga 2016-06-20 17:14:22 UTC 
(In reply to Eltomito from comment #6)
> This bug doesn't exist in LO 5.2.0.0 beta2, Linux version.

Still zeroing for me.

Did you really use the Ctrl-Shift-J fullscreen functionality?

Arch Linux 64-bit, KDE Plasma 5
Version: 5.3.0.0.alpha0+
Build ID: c13f60e7cd18df6b0ab70289f5b91ee01e4ae126
CPU Threads: 8; OS Version: Linux 4.6; UI Render: default; 
Locale: fi-FI (fi_FI.UTF-8)
Built on June 18th 2016
Comment 8 Yousuf Philips (jay) (retired) 2016-10-24 21:33:02 UTC 
Counts are lost in the word count dialog as focus wasnt restored back to the document after returning from fullscreen mode, but once the document regains focus, the counts return.

This should be something simple to fix, but definitely of least importance with the simple workaround of clicking the document.

Version: 5.3.0.0.alpha1+
Build ID: 928776b734c6aa188151bbce048d5bef4486dce7
CPU Threads: 2; OS Version: Linux 3.19; UI Render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2016-10-23_00:39:08
Locale: en-US (en_US.UTF-8); Calc: group
Comment 9 QA Administrators 2017-10-25 08:58:06 UTC Comment hidden (obsolete)
Comment 10 Yousuf Philips (jay) (retired) 2017-10-25 09:31:58 UTC 
Still present. In 3.3/3.4, the word count dialog was modal, so you couldnt go into fullscreen mode while it was open.

Version: 6.0.0.0.alpha1+
Build ID: 43d6b11a5c1dda0cc2c1e06c768eece25051a56c
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group

Maxim, Heiko, Stuart: Should a non-modal dialog get focus when exiting full screen mode or should the document? Should non-modal dialogs get closed when entering full screen mode?
Comment 11 Heiko Tietze 2017-10-25 11:19:03 UTC 
(In reply to Yousuf Philips (jay) from comment #10)
> Should a non-modal dialog get focus when exiting full
> screen mode or should the document? Should non-modal dialogs get closed when
> entering full screen mode?

This question is too generic. In most situations it makes no sense to switch the focus from document to any other dialog. And I don't see a use case to focus the word count- nor to make it a non-modal window at all.

In general, non-modal dialogs shouldn't get touched by the program, so to close when switching to full-screen mode is bad.
Comment 12 Yousuf Philips (jay) (retired) 2017-10-26 08:01:50 UTC 
(In reply to Heiko Tietze from comment #11)
> This question is too generic. In most situations it makes no sense to switch
> the focus from document to any other dialog.

Sounds good. So we keep focus on document, as it was in focus when in full screen mode.
Comment 13 QA Administrators 2018-10-27 02:56:07 UTC Comment hidden (obsolete)
Comment 14 QA Administrators 2020-10-27 04:25:14 UTC Comment hidden (obsolete)
Comment 15 QA Administrators 2022-10-28 03:33:03 UTC Comment hidden (obsolete)
Comment 16 QA Administrators 2024-10-28 03:12:47 UTC 
Dear leighman,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug