Bug 54953 - CALC: Enhance "Insert" label appearance and Insert/Overwrite tooltips (per Comment 15)
Summary: CALC: Enhance "Insert" label appearance and Insert/Overwrite tooltips (per Co...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
3.6.0.4 release
Hardware: Other All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: BSA
Keywords:
Depends on:
Blocks: Statusbar
  Show dependency treegraph
 
Reported: 2012-09-15 07:32 UTC by Philippe Clément
Modified: 2018-12-15 01:42 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Clément 2012-09-15 07:32:14 UTC
Problem description: 

Steps to reproduce:
1. In the status bar, the click does not switch to "insert" to "crush" must press the keyboard insertion

Platform : Windows 7 home family premium 64 bits LibreOffice 3.6.2.1 build ID : ba822cc
Comment 1 Jean-Baptiste Faure 2012-09-15 07:57:30 UTC
Reproducible for me with LO 3.6.2.1 under Ubuntu 12.04 x86_64 with FR lang-pack.

Works as expected in Writer but not in Calc.
I guess it is related to the following commit: http://cgit.freedesktop.org/libreoffice/core/commit/?id=b30e202861e9bdba4d86e76ba8a6f059da8efc31

@Kendy: Please, as it is your commit, could you have a look?

Best regards. JBF
Comment 2 QA Administrators 2015-01-05 17:51:29 UTC Comment hidden (obsolete)
Comment 3 Jean-Baptiste Faure 2015-01-07 06:04:02 UTC Comment hidden (obsolete)
Comment 4 QA Administrators 2016-01-17 20:02:56 UTC Comment hidden (obsolete)
Comment 5 Jan Holesovsky 2016-01-18 07:14:58 UTC
This has nothing to do with my change...

The core of the issue is I guess that Calc uses editeng as its text input & layout engine, and that one is not that connected to the sfx2 events mechanism (that is used in the statusbar); which is a non-trivial thing to fix :-(
Comment 6 Jean-Baptiste Faure 2016-01-18 08:23:27 UTC
(In reply to Jan Holesovsky from comment #5)
> This has nothing to do with my change...
> 
> The core of the issue is I guess that Calc uses editeng as its text input &
> layout engine, and that one is not that connected to the sfx2 events
> mechanism (that is used in the statusbar); which is a non-trivial thing to
> fix :-(

Hi Kendy, Thank you for the explanation.

To answer comment #4: still reproducible in 5.1.1.0.0+ and master.

Note: switching between insert and overwrite mode works only if the cursor is in the formula bar or if the current cell is in edit mode.

Best regards. JBF
Comment 7 Pedro 2017-01-03 15:02:49 UTC
This works as expected since version 4.4.7 (single click toggles between INS/OVER modes)

However since branch 4.0 the "Insert" word has vanished (at least under Windows 7) so there is an empty area which switches to Overwrite when clicked, but this is not obvious at all.

Should I open a new Bug report? This seems to be a Regression...
Comment 8 Timur 2018-08-06 15:59:17 UTC
We have 2 related issues here: no mouse toggle and INSERT not seen anymore.
Both worked with LO 3.5 so regression from 3.6. Is bibisect possible?
Note: mouse was sometimes able to just once toggle Overwrite to Insert (which is not displayed).
From 6.1 to 6.2+ mouse toggle works but Insert is still not seen. So let's keep this bug open. I'll open another one for recent regression from 6.1.
Comment 9 Joop Lanting 2018-08-06 16:27:18 UTC Comment hidden (obsolete)
Comment 10 Timur 2018-08-07 13:54:32 UTC Comment hidden (obsolete)
Comment 11 Xisco Faulí 2018-08-07 16:41:15 UTC Comment hidden (obsolete)
Comment 12 Jean-Baptiste Faure 2018-08-07 17:57:55 UTC Comment hidden (obsolete)
Comment 13 Xisco Faulí 2018-08-07 18:00:28 UTC
Ahh, ok, then let's leave it as just 'bibisected'...

Regression introduced in range https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=67ff63988f3b8eef2cc2b5bdf917918b93c3f070..877c96a601e6e50d0c7a8f704d57baec22f089c5
Comment 14 Maxim Monastirsky 2018-08-07 19:41:11 UTC
I don't understand. The original issue of not being able to switch to overwrite mode with a mouse click can't be reproduced anymore with 6.1+, as was already noted in comment 8. While the missing "Insert" text was actually an intentional change, as can be seen from Kendy's commit message. So which issue this bug is currently tracking?
Comment 15 Timur 2018-08-08 13:50:19 UTC
Since mouse change is possible, remaining issue is: "Insert" not seen anymore.

Kendy's commit message doesn't give explanation why Insert is not seen anymore. 
Guess because change is not possible unless in cell edit mode. Only than is tooltip displayed. So it's generally justified. 
Only mistake there is that last set tooltip remains when cell edit mode is over. 

Small enhancement NOW would be to:
1. show tooltip in select (not cell edit) mode, already available of fileopen: "Insert and Overwrite modes are available in cell edit mode" (to avoid confusion on use);
2. show "Insert" label while in cell edit mode that toggles with "Overwrite" label (and keep current informative tooltips);
3. when cell edit mode is over, again in select mode show similar tooltip "Insert and Overwrite modes are available in cell edit mode" (instead of keeping last tooltip from cell edit mode).

I change the title and set as Enhancement. Feel free to comment if you can improve.
Comment 16 Xisco Faulí 2018-12-14 18:48:02 UTC
An enhancement can't be a regression...
Comment 17 Pedro 2018-12-15 01:42:55 UTC
(In reply to Xisco Faulí from comment #16)
> An enhancement can't be a regression...

It worked in previous versions and no longer works, it is a regression (see comment #7)
The word INSERT is missing (but the tooltip is working). If you do click on an empty area (not expected from an UI) it will switch mode and Over will be displayed.

In my opinion enhancement and enhance do not apply to something broken...
See Timur's comment #15 for suggestions to fix this.