Bug Hunting Session
Bug 56627 - valgrind: sc_subsequent_filters_test in orcus
Summary: valgrind: sc_subsequent_filters_test in orcus
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.0.0.0.alpha0+ Master
Hardware: Other All
: medium normal
Assignee: Kohei Yoshida
URL:
Whiteboard: target:3.7.0
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-31 23:09 UTC by Caolán McNamara
Modified: 2012-11-01 13:22 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
valgrind log (7.12 KB, text/plain)
2012-10-31 23:09 UTC, Caolán McNamara
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Caolán McNamara 2012-10-31 23:09:38 UTC
Created attachment 69375 [details]
valgrind log

I didn't have time to debug into this to see if its a valid warning. export VALGRIND=memcheck and run the sc_subsequent_filters_test (I just move it from slowtest into gb_Module_add_check_targets and do export VALGRIND=memcheck && cd sc && make)
Comment 1 Kohei Yoshida 2012-10-31 23:21:13 UTC
Thanks. I'll take a look.

We'd already found and fixed another valgrind issue with the xml parser (for the next package release), but this one is apparently in the csv parser, so there is a good chance that it's still there...
Comment 2 Kohei Yoshida 2012-10-31 23:53:17 UTC
Ah, actually this is in the csv_handler inside sc, not in orcus proper.

The file is located in sc/qa/unit/helper/csv_handler.hxx.
Comment 3 Not Assigned 2012-11-01 00:50:19 UTC
Kohei Yoshida committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a05cfc077aebd71c8e882ec2c83cd7bd2b818401

fdo#56627: Handle empty cell values separately in filters test.



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 4 Kohei Yoshida 2012-11-01 13:22:08 UTC
I'll just close this. If this doesn't help, let me know.