Bug Hunting Session
Bug 57320 - FILESAVE: hidden text visible in HTML export
Summary: FILESAVE: hidden text visible in HTML export
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:4.0.0.0.beta2 target:4.1.0
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-20 12:12 UTC by libreoffice
Modified: 2012-12-11 18:56 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
write display:none for hidden text in HTML export (3.13 KB, patch)
2012-11-20 12:14 UTC, libreoffice
Details

Note You need to log in before you can comment on or make changes to this bug.
Description libreoffice 2012-11-20 12:12:02 UTC
Text with font effect "Hidden" is not marked as hidden in the HTML export.
Comment 1 libreoffice 2012-11-20 12:14:11 UTC
Created attachment 70308 [details]
write display:none for hidden text in HTML export
Comment 2 Michael Stahl (CIB) 2012-12-11 15:53:47 UTC
thanks for the patch!

could you please send a mail with a text like 
http://permalink.gmane.org/gmane.comp.documentfoundation.libreoffice.devel/38402
to the mailing list libreoffice@lists.freedesktop.org ?

then i can integrate it on master...

also, it's best to use "git format-patch" to create patches
(you first have to configure git user and email address, and "git commit" the patch), and it's also best to send the patch either to mailing list or to gerrit (http://wiki.documentfoundation.org/Development/gerrit) because
developers look there far more often than at bugzilla for patches.
Comment 3 libreoffice 2012-12-11 16:53:09 UTC
Thanks for looking at my patch! I've sent the license statement.
While you're at it, maybe you can take a look at my patch for bug 57254 (same problem for xhtml export) as well?
Comment 4 Not Assigned 2012-12-11 18:48:46 UTC
Arne de Bruijn committed a patch related to this issue.
It has been pushed to "libreoffice-4-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=71b4551ab80bd4f420b6284379bb9174fc93382c&g=libreoffice-4-0

fdo#57320: sw: HTML export: hidden text should not be visible


It will be available in LibreOffice 4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 5 Not Assigned 2012-12-11 18:49:20 UTC
Arne de Bruijn committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=45ca417bf90ea7873c4d75cd0611fcf0cf7a33a9

fdo#57320: sw: HTML export: hidden text should not be visible



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 6 Michael Stahl (CIB) 2012-12-11 18:56:39 UTC
thanks for the patch