Created attachment 73559 [details] Screenshot K. J. Wehorn's observation on <libreoffice-qa@lists.freedesktop.org> thread libreoffice-qa@lists.freedesktop.org is reproducible. Anywhere I see "4.0 .0.2" instead of "4.0.0.2"
that's not the About screen that K. J. Weghorn complained about but some installation program, so there are 2 problems.
The root is the sama: we abuse PRODUCTEXTENSION variable as the second part of version number.
well previously we were abusing SHORT_PRODUCTEXTENSION for the same purpose :)
Created attachment 73561 [details] About Screen András already anticipated my suspect concerning common root.
in my Windows master build i get in the About dialog "Version 4.1.0.0.alpha0+", and on Linux for my dbgutil build of 4.0RC2 i get "Version 4.0.0.2", so can't reproduce that problem. the Win installation wizard does have the spurious space in my master build. which i'm guessing is from instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf:en-US = "{&TahomaBold10}Welcome to the Installation Wizard for [ProductName]"
Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=3c0f360995741c16e93f49b1a1e771d0f4e40dc7 fdo#59798: MSI installer spurious space in version number The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e2d60ae0bf885a39bb392729797b0fc6ec3a5fe5 fdo#59798: fix SDK MSI version "LOdev 4.1 SDK.0.0.alpha0" The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
the 2 commits should fix the LO installer and LO SDK installer version strings. the reason why i'm getting the right version numbers in About dialog is that i'm using en_US build and you're not; i've changed some strings but forgot to tell timar about it so the translations are now out of sync.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-4-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=72f0e26b6a5f7b3bb32d713227de189e0a7a2b4f&h=libreoffice-4-0 fdo#59798: MSI installer spurious space in version number It will be available in LibreOffice 4.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-4-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c6a1ebfd96e0d05bd6b93d49dd3fdebc518c9328&h=libreoffice-4-0 fdo#59798: fix SDK MSI version "LOdev 4.1 SDK.0.0.alpha0" It will be available in LibreOffice 4.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Why isn't this cherry picked for 4.0.0? Isn't it in time for RC3? It's not an important bug but... it just looks sloppy... If it's already fixed why not include it?
It is nominated for 4.0 RC3 but it needs 3 reviews. I'm pretty sure that it will go in. I'm talking about the installer part. I fixed the About box in translations module in libreoffice-4-0-0 branch.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-4-0-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=55ede5572e4b242f73caaf557802ff38e6d1af29&h=libreoffice-4-0-0 fdo#59798: MSI installer spurious space in version number It will be available already in LibreOffice 4.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-4-0-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=67fcef018003a4baa8a758bb79cad459016009bc&h=libreoffice-4-0-0 fdo#59798: fix SDK MSI version "LOdev 4.1 SDK.0.0.alpha0" It will be available already in LibreOffice 4.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
*** Bug 59960 has been marked as a duplicate of this bug. ***