Bug 59902 - LibreOffice does not warn when opening a .sdw or .sdc file, therefore imports as ASCII
Summary: LibreOffice does not warn when opening a .sdw or .sdc file, therefore imports...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: filters and storage (show other bugs)
Version:
(earliest affected)
4.0.0.2 rc
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisectNotNeeded, regression
Depends on:
Blocks:
 
Reported: 2013-01-26 13:41 UTC by Gerry
Modified: 2017-07-12 20:54 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
example-starwriter-file.sdw (16.50 KB, application/vnd.stardivision.writer)
2013-01-26 19:47 UTC, Gerry
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gerry 2013-01-26 13:41:14 UTC
In bug 58231 on the removal of support for legacy binary StarOffice files: 1.0 -> 5.0, it was mentioned that there is a dummy filter warning the user when he/she wants to open a .sdw or .sdc file and that the file type support was removed.

Problem: However, there is no warning. LibreOffice simply imports the binary file as ASCII without warning. 

Solution: Please activate or implement the warning message such as indicated in bug 58231, comment 5 by Michael Meeks.

Tested in LibreOffice 4.0rc2
Comment 1 Jorendc 2013-01-26 18:18:16 UTC
Hi Gerry,

Is it possible to attach a sample file .sdw or .sdc, please? I'm not that familiar with this file extensions, so I can't test it right now (didn't see a bug report with this files either).

Thanks in advance,
Joren
Comment 2 Gerry 2013-01-26 19:47:57 UTC
Created attachment 73699 [details]
example-starwriter-file.sdw

Thanks for looking into this bug. Please find attached an example .sdw file.

The file formats of StarOffice (the predecessor of OpenOffice/LibreOffice) used these binary file formats until version 5.x. In some countries (e.g. Germany), StarOffice was very popular, so that many people still have old .sdw (Writer), .sdc (Calc), .sdd (Draw) files. 

For technical reasons the LibreOffice team decided to remove these old file formats. However, there was supposed to be a warning or dummy filter to inform the user.
Comment 3 Jorendc 2013-01-26 20:06:13 UTC
(In reply to comment #2)
> Created attachment 73699 [details]
> example-starwriter-file.sdw
> 
> For technical reasons the LibreOffice team decided to remove these old file
> formats. However, there was supposed to be a warning or dummy filter to
> inform the user.

I get your point and I saw Michael's message on the other bug. I indeed can't see any 'pointer to a website/info' or 'dummy filter'. When I try to open that document I can select a list of filters I can try to use.
Therefore I mark this bug as NEW.

Please, can you specify why you add 'regression' to the bug name? Did this work properly in previous versions of 4.0? (rc1 or so?).
Comment 4 Gerry 2013-01-27 11:44:58 UTC
In the original bug entry, I did not see any "list of filters", but the binary file just got imported as ASCII text to Writer, which - of course - doesn't make sense. Hence I did some more testing:

Situation A: If you open the file from the LibreOffice StartCentre, then you are pointed to a "list of filters" to choose from. 

Situation B: If you open Writer and choose "File" -> "Open" you do not get any "list of filters", but the binary file directly imports as ASCII file, which results in a bunch of crap.

In both situations, there is no dummy filter or warning for the user that the old StarOffice filters were removed and a hint what the user shall do.

I marked it as a regression for two reasons:
First, according to Michael there was a dummy filter (I assume in previous test releases) which is not there now.
Second, the import of the binary StarOffice file as ASCII is a regression over any previous version.
Comment 5 Gerry 2013-01-27 11:49:30 UTC
I added Michael to this bug, because I think he can clarify / find a solution.
Comment 6 Jorendc 2013-01-27 12:24:58 UTC
(In reply to comment #4)
> In the original bug entry, I did not see any "list of filters", but the
> binary file just got imported as ASCII text to Writer, which - of course -
> doesn't make sense. Hence I did some more testing:
> 
> Situation A: If you open the file from the LibreOffice StartCentre, then you
> are pointed to a "list of filters" to choose from. 
> 
> Situation B: If you open Writer and choose "File" -> "Open" you do not get
> any "list of filters", but the binary file directly imports as ASCII file,
> which results in a bunch of crap.
I can confirm that behavior.
> 
> In both situations, there is no dummy filter or warning for the user that
> the old StarOffice filters were removed and a hint what the user shall do.
> 
> I marked it as a regression for two reasons:
> First, according to Michael there was a dummy filter (I assume in previous
> test releases) which is not there now.
I agree with that point of view. But I don't know for sure it ever worked. Based on what Michael said I'll indeed mark this as a regression.

Therefore I mark this bug as a regression (in the keywords) and then I can delete it also from the title.
> Second, the import of the binary StarOffice file as ASCII is a regression
> over any previous version.
I'm absolutely not familiar with that, so I can't confirm this due my lack of experience for this :-).

Following [1] I can't decide which priority to set this bug report. I'll try to discuss this with another experienced QA member.
Comment 7 Jorendc 2013-01-27 12:25:23 UTC
(In reply to comment #6)
> Following [1] I can't decide which priority to set this bug report. I'll try
> to discuss this with another experienced QA member.
[1] = https://wiki.documentfoundation.org/images/0/06/Prioritizing_Bugs_Flowchart.jpg
Comment 8 Michael Meeks 2013-01-28 07:38:06 UTC
As that bug says - adding that warning is on our TODO - but is not yet done.
Patches greatly appreciated (as per bug#58231).
Comment 9 Robinson Tryon (qubit) 2015-12-10 07:49:52 UTC Comment hidden (obsolete)
Comment 10 QA Administrators 2017-01-03 19:42:44 UTC Comment hidden (obsolete)
Comment 11 osnola 2017-01-05 09:19:07 UTC
Hello,
normally, LibreOffice 5.3 will integrate a small filter: https://github.com/fosnola/libstaroffice/wiki to read old StarOffice binary files,  so adding a warning will no longer be needed.

Note:
- this filter is still in earlier stage, so the conversions of .sdw files will remain basic while the conversions of .sda and .sdc files must be better.
Comment 12 Gerry 2017-01-11 20:50:56 UTC
set to RESOLVED->FIXED as version 5.3 will include StarOffice filters. Thanks a lot!