Bug 60696 - Edit-Links - cleanup and make it work for movies ...
Summary: Edit-Links - cleanup and make it work for movies ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
4.0.0.3 release
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: reviewed:2023
Keywords: difficultyInteresting, easyHack, skillCpp, topicCleanup
Depends on:
Blocks: Hyperlink-Dialog
  Show dependency treegraph
 
Reported: 2013-02-11 21:25 UTC by Michael Meeks
Modified: 2023-12-23 13:55 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Meeks 2013-02-11 21:25:02 UTC
If you copy/paste an image from a website into LibreOffice - you'll notice that actually a linked image is created. Eg. right-click in firefox -> 'copy' and ctrl-v in writer.

This enables the Edit->Links dialog.

That dialog is -pretty- ugly - it should be converted to a .ui file and the code cleaned up cf. http://blogs.linux.ie/caolan/2013/01/24/converting-libreoffice-dialogs-to-ui-format-100-conversions-milestone/

But more than that - we can now link (or embed) Video files inside ODF files - which is really lovely (checkout the [x] link setting in the file selector). However - these don't show up in this dialog - which is a shame, I imagine we could do something useful with them there.

cui/source/dialogs/linkdlg.cxx and
cui/source/dialogs/svuidlg.hrc:#define MD_UPDATE_BASELINKS 32002
cui/source/dialogs/svuidlg.src:ModalDialog MD_UPDATE_BASELINKS

Are the places to poke at this code.

Thanks !
Comment 1 Michael Meeks 2013-02-11 21:28:08 UTC
Oh ! - I forgot; we can now embed palettes, bitmaps, line-styles and all manner of other pieces now - checkout the [embed] check-box when you:

insert a rectangle, right click on it, select 'Area', and then 'Color's and notice the '[x] Embed' check-box there.

We should potentially show all of those as well.
Comment 2 Björn Michaelsen 2013-10-04 18:46:44 UTC
adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility.

see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details
Comment 3 Robinson Tryon (qubit) 2013-10-23 16:48:23 UTC Comment hidden (obsolete)
Comment 4 Robinson Tryon (qubit) 2015-12-14 05:01:16 UTC Comment hidden (obsolete)
Comment 5 Robinson Tryon (qubit) 2016-02-18 14:51:34 UTC Comment hidden (obsolete)
Comment 6 Hossein 2023-12-23 13:55:45 UTC
Re-evaluating the EasyHack in 2023

This issue is not relevant anymore. The behavior described in the comment 0 is no longer reproducible, as no link is created. The dialog is already converted to cui/uiconfig/ui/baselinksdialog.ui, and MD_UPDATE_BASELINKS is no longer in use. Part of the task is done here:

commit d1f2e4d798b75f819d234912eb8ff9149eeaca42
Author: sk94 <eszkadev@gmail.com>
Date:   Mon Jun 2 14:58:37 2014 +0200

    MD_UPDATE_BASELINKS conversion to .ui

    Change-Id: I98b47dc20b341375c9caae264c2213aeba6e066a
    Reviewed-on: https://gerrit.libreoffice.org/9620

The discussed "link" option in "Edit" menu can be activated in Writer by using "Insert > Image", then choosing an image, and also making sure that "Link" check box is activated. You need to confirm the intent of having a link instead of embedding the graphic. This is done using the "Confirm Linked Graphic" dialog box with "Keep Link" button. After that, "Edit > External Links..." menu option will be activated. Then, the above dialog can be opened by using this menu option.

This is discussed in the LibreOffice help, in the link below:

Edit External Links
https://help.libreoffice.org/7.6/en-US/text/shared/01/02180000.html

The same can be done for movies using "Insert > Media > Audio or Video...".

Also, the "Area" dialog is changed a lot. Therefore, I change the status to RESOLVED/FIXED now.