It seems that large chunks of code are cut/pasted between a number of modules in writer: source/ui/shells/annotsh.cxx: case FN_WORDCOUNT_DIALOG: source/ui/shells/annotsh.cxx: pVFrame->ToggleChildWindow(FN_WORDCOUNT_DIALOG); source/ui/shells/drawsh.cxx: case FN_WORDCOUNT_DIALOG: source/ui/shells/drawsh.cxx: pVFrame->ToggleChildWindow(FN_WORDCOUNT_DIALOG); source/ui/shells/drwtxtex.cxx: case FN_WORDCOUNT_DIALOG: source/ui/shells/drwtxtex.cxx: pVFrame->ToggleChildWindow(FN_WORDCOUNT_DIALOG); source/ui/shells/frmsh.cxx: case FN_WORDCOUNT_DIALOG: source/ui/shells/frmsh.cxx: pVFrame->ToggleChildWindow(FN_WORDCOUNT_DIALOG); source/ui/shells/textsh.cxx: SFX_CHILDWINDOW_REGISTRATION(FN_WORDCOUNT_DIALOG); source/ui/shells/textsh1.cxx: case FN_WORDCOUNT_DIALOG: source/ui/shells/textsh1.cxx: pVFrame->ToggleChildWindow(FN_WORDCOUNT_DIALOG); if would be excellent to find a common place for that code to go, and to factor it out into a single shared module. At least - it seems so to me :-)
Michael - it'd be great to have some idea of where that duplication should ultimately end-up :-) [ assuming it can end up somewhere ].
Cedric, we need somebody who knows anything about those mysterious "shells" to answer comment #2.
(In reply to comment #2) > Cedric, we need somebody who knows anything about those > mysterious "shells" to answer comment #2. Those shells are different UI parts. The only place where such a factorization could happen is the SwView as it seems to be handling already most of the job. We still have to Invalidate the shell, but that would simplify the code a bit.
adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility. see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details
Removing comma from whiteboard (please use a space to delimit values in this field) https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Whiteboard#Getting_Started
Restricted my LibreOffice hacking area
Hi people, I would like to solve this bug. Any advice for the common place for that code?
Lenka - it'd be great to have you working on that =) what I'd suggest you do is to whack it in one of the source/ui pieces - and then some purist will come along and sort that out; the key piece is doing the careful de-duplication - analysing the problem & hacking out the bloat: then trying to work out if the special cases / differences are deliberate or accidental ;-) Beyond that the naming of the new headers / classes is up to your creativity - it's easy to search/replace them in the patch usually as long as they are reasonably unique. Thanks so much for looking at this !
adding LibreOffice developer list as CC to unresolved Writer EasyHacks for better visibility. see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details
Factorise FN_WORDCOUNT_DIALOG case in https://gerrit.libreoffice.org/14182 . More cases could be cleaned up : FN_FORMAT_FOOTNOTE_DLG FN_NUMBERING_OUTLINE_DLG: SID_OPEN_XML_FILTERSETTINGS ... I'm planning to change the other ones, referencing this bug. Any objection ?
Michaël Lefèvre committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d57cd80479fac60a2486c74257a8840e36935e20 tdf#60739 code factorisation It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michaël Lefèvre committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0bac0582adac70380fe30ed16247b1b9f91d2680 tdf#60739 code factorisation It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michaël Lefèvre committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0473818b3ebd8446a40cffa6a83b985dc3d9d1a0 tdf#60739 code factorisation It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michaël Lefèvre committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=71c49bcfa0677f013684030defbf5ead21695d85 tdf#60739 code factorisation It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Migrating Whiteboard tags to Keywords: (EasyHack DifficultyBeginner SkillCpp TopicCleanup) [NinjaEdit]
JanI is default CC for Easy Hacks (Add Jan; remove LibreOffice Dev List from CC) [NinjaEdit]