Bug 60785 - RTL UI: Undo/Redo buttons point to the wrong direction
Summary: RTL UI: Undo/Redo buttons point to the wrong direction
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-13 12:18 UTC by Issa Alkurtass
Modified: 2013-02-13 13:36 UTC (History)
0 users

See Also:
Crash report or crash signature:

Attachments
Screenshot showing the wrong behavior of the icons. (1.36 KB, image/png)
2013-02-13 12:18 UTC, Issa Alkurtass 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Issa Alkurtass 2013-02-13 12:18:51 UTC 
Created attachment 74746 [details]
Screenshot showing the wrong behavior of the icons.

The icons for the Undo/Redo buttons are the same for both LTR and RTL interfaces. The undo icon should point to the left in LTR and to right in RTL and vice versa for the redo.

Wrong behavior: |--> redo|<-- undo|
Right behavior: |<-- redo|--> undo|
Comment 1 Issa Alkurtass 2013-02-13 12:23:04 UTC 
I've solved this and it has already been merged with master https://gerrit.libreoffice.org/#/c/1712/

Please note that currently special icons are assigned per language rather than interface (possibly for people to create their own Bold/Italic/Underlined buttons), hence I have assigned the RTL icons to each of Arabic (ar), Hebrew (he) and Farsi (fa).
Comment 2 Lior Kaplan 2013-02-13 13:33:21 UTC 
Committed to master as c56651e76c2dc8068d53406dcdd6cb6bd1bd9bce
and to 4-0 branch as 7e852d137ea8cd4898e67747d411e0de8710aedc

Verified on 4.0.0 and master.