Created attachment 74750 [details] File triggering the error When I open the attached document, libreoffice 4.0 (unlike previous versions, the problem seems absent in 3.6) shows only the very first of eight pages. Since not showing eight pages of content without any warning is a major issue, I consider this a critical regression, which should be fixed ASAP. The problem seems to be triggered by the use of macro placeholders in the file (two fields to be filled in, whose content is then shown elsewhere in the document).
Created attachment 74751 [details] Correct PDF output from MSO2012
Created attachment 74752 [details] False output from LibreOffice 4.0
I can confirm this behavior using Linux Mint 14 x64 with LibreOffice 4.0.0. Therefore I mark this as NEW. I can't test with latest master due Bug 61000. Following [1] I mark this bug as 'Major medium': * Major: inability to open a document (correctly) * medium, not high, because it CAN open but not complete [1] https://wiki.documentfoundation.org/images/0/06/Prioritizing_Bugs_Flowchart.jpg
This is a regression (see bibisect log).
Created attachment 74980 [details] bibisect40 log bibisect range: http://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=d59024b652ccfaf7247da113ec36788fe260de74..15af925c254f27046427de70a59011e2ac3d6bdb
@Miklos, Michael: in the bibisectrange I see some commits to writer from both of you. As non-developer I can't determine which commit broke the fileopen of this kind of document. Thanks for looking at this, Kind regards, Joren
Joren: Thank you so much for the bi-bisect, I've found the offending commit thanks to that really quickly. It is: 8c0a8d9db351fc05534d7552036889543f3a89d4 is the first bad commit commit 8c0a8d9db351fc05534d7552036889543f3a89d4 Author: Miklos Vajna <vmiklos@suse.cz> Date: Thu Jul 12 11:07:41 2012 +0200 writerfilter: read w:commentRangeStart and w:commentRangeEnd elements Change-Id: I8da1e43ffe6a78f14ab0901ae73c4ee39f1cbe44 :040000 040000 0452fd355fdeb88eb7f6706f6445f2f36e25515a 691a9668643be1565068c09eee33ebb5aa7c82bf M writerfilter Miklos: Can you please have a look? Thank you!
i started looking at this yesterday, and the problem is that there is a commentRangeStart in the document and immediately next is a text field, and inserting the text field calls SwXTextCursor::setString() which disposes the bookmark of the SwXTextRange that is stored as m_aAnnotationPosition.m_xStart in writerfilter. then inserting the annotation on the disposed text range throws; the exception is easy to handle but then we're missing 2 of the comments on the first page...
Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4c165c708ce852b4d52527422b327b2f6ad73685 fdo#60789: writerfilter: continue the import if comment insertion fails The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6145c6efa4f346287ed9693c9d00038d829d5a35 fdo#60789: writerfilter: do not insert a character at field start The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-4-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a09865cc0f177a28622330866b3ad5baf4b99bd6&h=libreoffice-4-0 fdo#60789: writerfilter: continue the import if comment insertion fails It will be available in LibreOffice 4.0.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-4-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=310b5976bb827a0ffb274f70878852e4474a0559&h=libreoffice-4-0 fdo#60789: writerfilter: do not insert a character at field start It will be available in LibreOffice 4.0.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thank you Michael; I'll test tomorrow with daily builds (can't build today).
Thank you everyone, I am absolutely impressed by the responsiveness of libreoffice - with openoffice.org, many bugs I reported are still not worked on. Great job!
I guess we can close the bug now :-) Michael - thanks for the fix!