Currently the dictionary names are not validated, and user can create a dictionary with characters like / in their names. Such dictionary is not saved into file, but it can be used, despite being irrecoverably lost after Writer terminates.
Indeed. Reproducible steps: 1. Open a new writer document 2. Type some nonsense words 3. F7 for spelling and grammar 4. Go to Options 5. New... 6. Make a new dictionary that begins with / 7. Click Ok Results: Dictionary appears to work in current sheet but then is lost as Urmas states because of illegal use of character Expected: LibreOffice should provide error and demand different name ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Changing version to reflect oldest tested version: 3.6.4.3 Bodhi Linux Marking as: New (confirmed) Major (loss of data, no error) High (default, no need to change) Thanks Urmas for the report
Code pointer: core/cui/source/options/optdict.cxx:119
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (4.4.0.3 or later): https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) Thank you for your help! -- The LibreOffice QA Team This NEW Message was generated on: 2015-02-19
Reproduced. Win 7 Pro 64-bit, LibO Version: 4.4.1.2 Build ID: 45e2de17089c24a1fa810c8f975a7171ba4cd432 Locale: fi_FI
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (5.0.5 or 5.1.2 https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT - Update the version field - Reply via email (please reply directly on the bug tracker) - Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for your help! -- The LibreOffice QA Team This NEW Message was generated on: 2016-04-16
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (5.2.7 or 5.3.3 https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug-20170522
Still reproducible with Version: 6.2.0.0.alpha1+ Build ID: 612a107464c1889fdc4806a3c86da8c2fbf452c8 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: de-DE (de_DE.UTF-8); Calc: threaded
Submitted patch for this bug: https://gerrit.libreoffice.org/#/c/71059/ Joel Madero, I hope you don't mind that I added you as a reviewer, I'm still not sure on the etiquette for setting reviewers. In the process of fixing this, I found that you can also set a dictionary with no name. The 'OK' button should be inactive when nothing has been entered into the input field.
(In reply to Ritchie Cunningham from comment #8) > Submitted patch for this bug: https://gerrit.libreoffice.org/#/c/71059/ > > Joel Madero, I hope you don't mind that I added you as a reviewer, I'm still > not sure on the etiquette for setting reviewers. > > In the process of fixing this, I found that you can also set a dictionary > with no name. The 'OK' button should be inactive when nothing has been > entered into the input field. Joel's role in this report was just to confirm it as a QA team member. I can test the patch later myself.
I built with the patch and confirm that it now prevents us from starting a dictionary name with /
(In reply to Buovjaga from comment #10) > I built with the patch and confirm that it now prevents us from starting a > dictionary name with / Thank you. It prevents both '\' and '/' As they both cause data loss. It will also prevent a name like 'new/dict.dic' as this would trim the name to 'dict.dic'
Patch restored in gerrit
Rtch90 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/c78306fb47011a3c050368b9696cb2d5ecf3d57d%5E%21 tdf#61076 string validation on creation of new dictionary. It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.