Bug 63130 - FILESAVE Working with a large Visio 2003 Drawing is slow
Summary: FILESAVE Working with a large Visio 2003 Drawing is slow
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
4.0.2.2 release
Hardware: x86-64 (AMD64) All
: low minor
Assignee: Not Assigned
URL:
Whiteboard: target:7.6.0
Keywords: filter:visio, haveBacktrace, perf
Depends on:
Blocks: MSO-XML2003 Visio
  Show dependency treegraph
 
Reported: 2013-04-04 16:37 UTC by Jeff L.
Modified: 2023-11-03 15:37 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
dump file (156.81 KB, text/plain)
2013-04-04 16:42 UTC, Jeff L.
Details
attachment-23495-0.html (2.46 KB, text/html)
2013-08-26 16:14 UTC, Jeff L.
Details
attachment-23495-1.dat (1 bytes, multipart/alternative)
2013-08-26 16:14 UTC, Jeff L.
Details
Example Campus Design.zip (2.61 MB, application/x-zip-compressed)
2013-08-26 16:14 UTC, Jeff L.
Details
console + bt with symbols on master sources (3.59 KB, application/x-bzip)
2013-08-26 17:07 UTC, Julien Nabet
Details
Perf flamegraph (119.21 KB, image/svg+xml)
2021-09-16 14:38 UTC, Buovjaga
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff L. 2013-04-04 16:37:56 UTC
Windows 7 Professional SP1 64bit
Thinkpad T410
i7 Quad Core
4GB Ram

I opend a Large 3.08MB Visio 2003 drawing (Network Design). File opens fine but when trying to navigate around the document I get "Not Responding" and then "Libraoffice has stopped working" error. 
Reopened the LibraOffice and sucessfuly restored the document, try to save the file and Draw hangs and crshes. Is repeatable.

Attachments:
Windows Crash files
Comment 1 Jeff L. 2013-04-04 16:42:57 UTC
Created attachment 77436 [details]
dump file

windows Dump file .mdmp (3MB) available if needed
Comment 2 Julien Nabet 2013-04-05 21:50:38 UTC Comment hidden (obsolete)
Comment 3 Jeff L. 2013-05-22 18:58:59 UTC
Sorry this has taken me so long to get back to you. 

Unfortunately I can not share this drawing, as the drawing is company proprietary. I can describe it as a large D size drawing of a large datacenter network with close to 100 network switches, of varying types from standalone rack mounted switches with as many as 40 ports to large chassis based switches with their network ports numbering in the 100’s.
There were about 100 individual lines depicting the connectivity between the switches (not a port to port depiction, but switch to switch). I will try to find a similar drawing if I can and see If I can recreate the issue by adding more models into the drawing and increasing it’s size and complexity

Regards,

Jeff



From: bugzilla-daemon@freedesktop.org 
Sent: Friday, April 05, 2013 5:50 PM
To: js_laurenza@hotmail.com 
Subject: [Bug 63130] FILESAVE Libreoffice has stopped working when saving or working with large Visio 2003 Drawing

Julien Nabet changed bug 63130 
      What Removed Added 
      Status UNCONFIRMED  NEEDINFO  
      CC    serval2412@yahoo.fr  
      Ever confirmed    1  


Comment # 2 on bug 63130 from Julien Nabet 
Is it possible you attach the Visio file so we can try to reproduce this?
--------------------------------------------------------------------------------
You are receiving this mail because: 
  a.. You reported the bug.
Comment 4 Julien Nabet 2013-05-22 20:54:48 UTC Comment hidden (obsolete)
Comment 5 Julien Nabet 2013-08-24 06:14:33 UTC Comment hidden (obsolete)
Comment 6 Jeff L. 2013-08-26 16:14:06 UTC
Created attachment 84662 [details]
attachment-23495-0.html

Try this file. It’s slightly different than the original file I was using but it still crashed when simply scrolling up and down. This file however did not crash when trying to save it like the other file did. The files are similar in size but the other file was roughly one third larger.
I’m currently using Libre Office version - 4.0.3.3 (Build ID: 0eaa50a932c8f2199a615e1eb30f7ac74279539)



From: bugzilla-daemon@freedesktop.org 
Sent: Saturday, August 24, 2013 2:14 AM
To: js_laurenza@hotmail.com 
Subject: [Bug 63130] FILESAVE Libreoffice has stopped working when saving or working with large Visio 2003 Drawing


Comment # 5 on bug 63130 from Julien Nabet 
Jeff: any file you may attach so we can try to reproduce the problem?
--------------------------------------------------------------------------------
You are receiving this mail because: 
  a.. You reported the bug.
Comment 7 Jeff L. 2013-08-26 16:14:06 UTC
Created attachment 84663 [details]
attachment-23495-1.dat
Comment 8 Jeff L. 2013-08-26 16:14:06 UTC
Created attachment 84664 [details]
Example Campus Design.zip
Comment 9 Julien Nabet 2013-08-26 17:07:09 UTC
Created attachment 84665 [details]
console + bt with symbols on master sources

On pc Debian x86-64 with master sources updated today, I didn't reproduce crash but it's quite slow.
I attached console logs + 3 bts.

Jeff: please don't answer from your emailer but from:
- https://bugs.freedesktop.org/show_bug.cgi?id=63130#add_comment if you just want to add a comment
- https://bugs.freedesktop.org/attachment.cgi?bugid=63130&action=enter if you want to attach a file + let a comment
Comment 10 Julien Nabet 2013-08-26 17:08:21 UTC Comment hidden (obsolete)
Comment 11 Winfried Donkers 2013-12-11 12:26:42 UTC
I confirm the behaviour with attachment 84664 [details], Windows 7 pro SP1 32 bit, MS Visio 2007 and LibreOffice Writer, bith with version 4.1.3.2 and 4.2.0.0beta2.

Used method:
-open visio drawing with Visio
-opened existing Writer document
-in visio, selected all with Ctrl-A and copied to clipboard with Ctrl-C
-in writer:
 4.2.0 : paste nor past-special were available (object too large?)
 4.1.3 : paste special with Shift-Ctrl-V and selected visio object. Object seemed to be pasted, but after minutes of busy machine, Writer crashed. The repair-dialog appeared, but could not succeed in succesfully repairing (it did report so) and opening the document. Only way out was to cancel repair.

Copy/paste special of parts of the Visio drawing (50% or less) does work, though.

Visio, LibreOffice 4.1.3 and 4.2.0 were all open simultaneously.

Hardware information:
2GB RAM, pentium processor, Windows performance index 3.3
Comment 12 QA Administrators 2015-04-19 03:22:23 UTC Comment hidden (noise)
Comment 13 Winfried Donkers 2015-04-20 05:52:32 UTC
I confirm the behaviour with attachment 84664 [details], Windows 7 pro 64 bit, MS Visio 2007 and LibreOffice Writer version 4.4.2.2

Used method:
-open visio drawing from attachment 84664 [details] with Visio
-open existing Writer document
-in visio, select all with Ctrl-A and copied to clipboard with Ctrl-C
-in writer:
 paste shows an hourglass for some seconds, but nothing else happens (nothing is pasted, the document can be used and has not changed).
 paste special (Shift-Ctrl-V and selected visio object) produces the same result, possibly the hourglass shows a bit longer, but did not time.

There is improvement when comparing with version 4.2, but a message that the object is too large (if that should be the case) would be expected.

Copy/paste of parts of the Visio drawing (50% or less) does work, though.
Comment 14 Jeff L. 2015-10-29 17:41:07 UTC
Tried the Drawing file in LibreOffice v4.2.8.2 and this problem doesnt happen. However I'm using Linux RHEL 6.7 whereas I had been using Windows 7 when I initially reported this bug.

As I no longer have a Windows system I am unable to verify that the issue is completely fixed but I am satisfied with the performance of the application on RHEL on my new Lenovo W540 - Core i7 vPro, w/32GB of RAM.

Bug can be closed based on your confidence  of it being fixed. Thanks For the Work you all do!!
Comment 15 Julien Nabet 2015-10-29 17:44:56 UTC
Version field correspond to the earliest known LO version which contains the bug.

Now the problem is Winfried tested a more recent version and reproduced this.
So either there's a regression or I missed the point.

Winfried: any thoughts?
Comment 16 Winfried Donkers 2015-10-30 07:06:02 UTC
(In reply to Julien Nabet from comment #15)
> Winfried: any thoughts?

I tested again with attachment 84664 [details], Windows 7 pro SP1 32 bit, MS Visio 2007 and LibreOffice Writer, version 4.4.5.2.

Used method:
-open visio drawing with Visio
-opened existing Writer document
-in visio, selected all with Ctrl-A and copied to clipboard with Ctrl-C
-in writer:
 -paste shows an hourglass for some seconds, but nothing happens, nothing is pasted
 -past special shows dialog from I choose 'Microsoft Visio drawing'; further as with paste

Selecting smaller chunks from the Visio drawing (approx 40% and 60%) worked fine with copy/paste as well as with paste special.

Setting status back to NEW and OS to Windows as this is specific for Windows; there is no Microsoft Visio for Linux AFAIK.
Comment 17 QA Administrators 2016-11-08 12:02:26 UTC Comment hidden (noise)
Comment 18 QA Administrators 2021-08-27 04:04:31 UTC Comment hidden (noise)
Comment 19 Timur 2021-09-16 09:29:07 UTC
This bug is not straightforward to test.
But on moving around in opened attachment 84664 [details], I get a crash in LO 4.0 and 5.0 in Windows but not in LO 6.4 and 7.3+. 
So no crash, but LO should be faster, if possible.
Comment 20 Buovjaga 2021-09-16 14:38:52 UTC
Created attachment 175076 [details]
Perf flamegraph

This is a flamegraph of zooming.

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: e58e828d4877f9068e4a69c52ac9c7fe6e65d032
CPU threads: 8; OS: Linux 5.14; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Comment 21 Jeff L. 2022-02-10 15:57:18 UTC
I can no longer reproduce this crash.
Comment 22 Julien Nabet 2022-02-10 16:10:51 UTC
Since there's no specific patch here, it shouldn't be FIXED.

Let's rather put this one to WFM (unless we should "recycle" this bug for slowliness symptom ?)
Comment 23 Buovjaga 2022-02-11 20:42:51 UTC
Back to new as this was changed to be about perf.
Comment 24 Commit Notification 2023-05-16 05:58:08 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/83650c82b56f496cd165981aa34edef9d5547697

tdf#63130 make B2DHomMatrix a flat object

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 25 Commit Notification 2023-05-16 13:14:01 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3d6b0594267e42945a87bc98105a2e820d2229f6

tdf#63130 flatten the extra ImplMatLine into ImplHomMatrixTemplate

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 26 Commit Notification 2023-05-17 13:26:31 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a78a9ea3a5f935bf364f59426b22e9039d2c1784

tdf#63130 use a simpler, SIMD-friendly algorithm for matrix invert

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 27 Commit Notification 2023-05-17 18:28:17 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/67c3b3becab2aa2b9522e3a092d46bfe507c3101

tdf#63130 when getting the size, do not do a full paint

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 28 Commit Notification 2023-05-18 07:17:15 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7be8430702d433ce981d65fdf12e510c1cddda53

tdf#63130 reduce duplicated work when pixel snapping

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 29 Commit Notification 2023-05-18 07:17:18 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8afcd6e74fd8f36a5599a852383ffdb59ed734e9

tdf#63130 improve the performance in librevenge

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 30 Commit Notification 2023-05-18 13:15:54 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5a4d78d9a9b45c7fa387b66f5e310447ec813034

tdf#63130 reduce large memory copies when reading from BinaryDataContainer

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 31 Commit Notification 2023-05-21 17:51:54 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f4c24da1e7f11664e0d2f688d2531f068e4a3bc0

Revert "tdf#63130 when getting the size, do not do a full paint"

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 32 Roman Kuznetsov 2023-05-21 18:44:06 UTC
7 sec for opening in

Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 1fec168aff4569827d4822c9fcff7bc4ecd0d04b
CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL threaded

AMD Ryzen 7 5700U here

but I don't see so much difference with 7.5.0.3 on the same hardware, the file was opened for ~8 sec

There are some delays when you try to scroll/to scale the page in Draw in both versions