Download it now!
Bug 63426 - presentation wizard crashes
Summary: presentation wizard crashes
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.1.0.0.alpha0+ Master
Hardware: Other All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:4.1.0
Keywords:
Depends on:
Blocks: mab4.1
  Show dependency treegraph
 
Reported: 2013-04-11 13:57 UTC by Caolán McNamara
Modified: 2013-04-11 14:48 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Caolán McNamara 2013-04-11 13:57:02 UTC
wizards->presentation->next->abstract green

this is a regression from 13e8f68e82713cae2d081a236b260bda12aafa23

valgrind says:
==18064== Invalid read of size 8
==18064==    at 0x653E988: SfxItemSet::GetPool() const (itemset.hxx:142)
==18064==    by 0x66059E0: SfxRequest::GetItem(SfxItemSet const*, unsigned short, bool, void* (*)()) (request.cxx:491)
==18064==    by 0x67D83CE: SfxObjectShell::DoLoad(SfxMedium*) (objstor.cxx:621)
==18064==    by 0x6523922: SfxApplication::LoadTemplate(SfxObjectShellLock&, String const&, unsigned char, SfxItemSet*) (appopen.cxx:380)
==18064==    by 0x2FD84A6B: AssistentDlgImpl::UpdatePreview(unsigned char) (dlgass.cxx:1607)
==18064==    by 0x2FD82B44: AssistentDlgImpl::UpdatePreviewHdl(void*) (dlgass.cxx:1280)
==18064==    by 0x2FD82B20: AssistentDlgImpl::LinkStubUpdatePreviewHdl(void*, void*) (dlgass.cxx:1278)
==18064==    by 0x8FB7DFF: Link::Call(void*) const (link.hxx:123)
==18064==    by 0x8FDD130: Timer::Timeout() (timer.cxx:245)
==18064==    by 0x8FDCD99: Timer::ImplTimerCallbackProc() (timer.cxx:133)
==18064==    by 0x16E2B190: SalTimer::CallCallback() (saltimer.hxx:53)
==18064==    by 0x16E2A671: sal_gtk_timeout_dispatch (gtkdata.cxx:837)
==18064==    by 0x3D5F047A54: g_main_context_dispatch (gmain.c:2715)
==18064==    by 0x3D5F047D87: g_main_context_iterate.isra.24 (gmain.c:3290)
==18064==    by 0x3D5F047E43: g_main_context_iteration (gmain.c:3351)
==18064==    by 0x16E29985: GtkData::Yield(bool, bool) (gtkdata.cxx:582)
==18064==    by 0x16E2D907: GtkInstance::Yield(bool, bool) (gtkinst.cxx:562)
==18064==    by 0x8FD1D0D: ImplYield(bool, bool) (svapp.cxx:422)
==18064==    by 0x8FCDD24: Application::Yield(bool) (svapp.cxx:456)
==18064==    by 0x9459C8F: Dialog::Execute() (dialog.cxx:919)
==18064==    by 0x2FDB5928: AbstractAssistentDlg_Impl::Execute() (sddlgfact.cxx:56)
==18064==    by 0x227ABE95: SdModule::ExecuteNewDocument(SfxRequest&) (sdmod1.cxx:574)
==18064==    by 0x227AA79B: SdModule::Execute(SfxRequest&) (sdmod1.cxx:205)
==18064==    by 0x227A8FCE: SfxStubSdModuleExecute(SfxShell*, SfxRequest&) (sdslots.hxx:964)
==18064==    by 0x660AB7B: SfxShell::CallExec(void (*)(SfxShell*, SfxRequest&), SfxRequest&) (shell.hxx:185)
==18064==    by 0x68CCB1C: SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, unsigned char) (in /home/caolan/LibreOffice/core/solver/unxlngx6/lib/libsfxlo.so)
==18064==    by 0x68CEF7A: SfxDispatcher::_Execute(SfxShell&, SfxSlot const&, SfxRequest&, unsigned short) (in /home/caolan/LibreOffice/core/solver/unxlngx6/lib/libsfxlo.so)
==18064==    by 0x65ED086: SfxBindings::Execute_Impl(SfxRequest&, SfxSlot const*, SfxShell*) (bindings.cxx:1283)
==18064==    by 0x66477C1: SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) (unoctitm.cxx:736)
==18064==    by 0x6645ACC: SfxOfficeDispatch::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (unoctitm.cxx:369)
==18064==    by 0x290BF005: framework::NewMenuController::ExecuteHdl_Impl(framework::NewMenuController*, framework::NewDocument*) (newmenucontroller.cxx:540)
==18064==    by 0x8FB7DFF: Link::Call(void*) const (link.hxx:123)
==18064==    by 0x956A8CF: ImplHandleUserEvent(ImplSVEvent*) (winproc.cxx:1986)
==18064==    by 0x956BBB8: ImplWindowFrameProc(Window*, SalFrame*, unsigned short, void const*) (winproc.cxx:2557)
==18064==    by 0x957A196: SalFrame::CallCallback(unsigned short, void const*) const (in /home/caolan/LibreOffice/core/solver/unxlngx6/lib/libvcllo.so)
==18064==    by 0x9579C21: SalGenericDisplay::DispatchInternalEvent() (gendisp.cxx:91)
==18064==    by 0x16E2AA6F: GtkData::userEventFn(void*) (gtkdata.cxx:938)
==18064==    by 0x16E2AACA: call_userEventFn (gtkdata.cxx:948)
==18064==    by 0x3D5F047A54: g_main_context_dispatch (gmain.c:2715)
==18064==    by 0x3D5F047D87: g_main_context_iterate.isra.24 (gmain.c:3290)
==18064==    by 0x3D5F047E43: g_main_context_iteration (gmain.c:3351)
==18064==    by 0x16E29933: GtkData::Yield(bool, bool) (gtkdata.cxx:577)
==18064==    by 0x16E2D907: GtkInstance::Yield(bool, bool) (gtkinst.cxx:562)
==18064==    by 0x8FD1D0D: ImplYield(bool, bool) (svapp.cxx:422)
==18064==    by 0x8FCDD24: Application::Yield(bool) (svapp.cxx:456)
==18064==    by 0x8FCDCC5: Application::Execute() (svapp.cxx:401)
==18064==    by 0x4ED9249: desktop::Desktop::Main() (app.cxx:1736)
==18064==    by 0x8FDA475: ImplSVMain() (svmain.cxx:162)
==18064==    by 0x8FDA55E: SVMain() (svmain.cxx:198)
==18064==    by 0x4F1BFAD: soffice_main (sofficemain.cxx:82)
==18064==  Address 0x18a28ee8 is 8 bytes inside a block of size 80 free'd
==18064==    at 0x4A0738C: operator delete(void*) (vg_replace_malloc.c:480)
==18064==    by 0x6EC45A7: SfxAllItemSet::~SfxAllItemSet() (itemset.hxx:166)
==18064==    by 0x6523904: SfxApplication::LoadTemplate(SfxObjectShellLock&, String const&, unsigned char, SfxItemSet*) (appopen.cxx:379)
==18064==    by 0x2FD84A6B: AssistentDlgImpl::UpdatePreview(unsigned char) (dlgass.cxx:1607)
==18064==    by 0x2FD82B44: AssistentDlgImpl::UpdatePreviewHdl(void*) (dlgass.cxx:1280)
==18064==    by 0x2FD82B20: AssistentDlgImpl::LinkStubUpdatePreviewHdl(void*, void*) (dlgass.cxx:1278)
==18064==    by 0x8FB7DFF: Link::Call(void*) const (link.hxx:123)
==18064==    by 0x8FDD130: Timer::Timeout() (timer.cxx:245)
==18064==    by 0x8FDCD99: Timer::ImplTimerCallbackProc() (timer.cxx:133)
==18064==    by 0x16E2B190: SalTimer::CallCallback() (saltimer.hxx:53)
==18064==    by 0x16E2A671: sal_gtk_timeout_dispatch (gtkdata.cxx:837)
==18064==    by 0x3D5F047A54: g_main_context_dispatch (gmain.c:2715)
==18064==    by 0x3D5F047D87: g_main_context_iterate.isra.24 (gmain.c:3290)
==18064==    by 0x3D5F047E43: g_main_context_iteration (gmain.c:3351)
==18064==    by 0x16E29985: GtkData::Yield(bool, bool) (gtkdata.cxx:582)
==18064==    by 0x16E2D907: GtkInstance::Yield(bool, bool) (gtkinst.cxx:562)
==18064==    by 0x8FD1D0D: ImplYield(bool, bool) (svapp.cxx:422)
==18064==    by 0x8FCDD24: Application::Yield(bool) (svapp.cxx:456)
==18064==    by 0x9459C8F: Dialog::Execute() (dialog.cxx:919)
==18064==    by 0x2FDB5928: AbstractAssistentDlg_Impl::Execute() (sddlgfact.cxx:56)
==18064==    by 0x227ABE95: SdModule::ExecuteNewDocument(SfxRequest&) (sdmod1.cxx:574)
==18064==    by 0x227AA79B: SdModule::Execute(SfxRequest&) (sdmod1.cxx:205)
==18064==    by 0x227A8FCE: SfxStubSdModuleExecute(SfxShell*, SfxRequest&) (sdslots.hxx:964)
==18064==    by 0x660AB7B: SfxShell::CallExec(void (*)(SfxShell*, SfxRequest&), SfxRequest&) (shell.hxx:185)
==18064==    by 0x68CCB1C: SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, unsigned char) (in /home/caolan/LibreOffice/core/solver/unxlngx6/lib/libsfxlo.so)
==18064==    by 0x68CEF7A: SfxDispatcher::_Execute(SfxShell&, SfxSlot const&, SfxRequest&, unsigned short) (in /home/caolan/LibreOffice/core/solver/unxlngx6/lib/libsfxlo.so)
==18064==    by 0x65ED086: SfxBindings::Execute_Impl(SfxRequest&, SfxSlot const*, SfxShell*) (bindings.cxx:1283)
==18064==    by 0x66477C1: SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) (unoctitm.cxx:736)
==18064==    by 0x6645ACC: SfxOfficeDispatch::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (unoctitm.cxx:369)
==18064==    by 0x290BF005: framework::NewMenuController::ExecuteHdl_Impl(framework::NewMenuController*, framework::NewDocument*) (newmenucontroller.cxx:540)
==18064==    by 0x8FB7DFF: Link::Call(void*) const (link.hxx:123)
==18064==    by 0x956A8CF: ImplHandleUserEvent(ImplSVEvent*) (winproc.cxx:1986)
==18064==    by 0x956BBB8: ImplWindowFrameProc(Window*, SalFrame*, unsigned short, void const*) (winproc.cxx:2557)
==18064==    by 0x957A196: SalFrame::CallCallback(unsigned short, void const*) const (in /home/caolan/LibreOffice/core/solver/unxlngx6/lib/libvcllo.so)
==18064==    by 0x9579C21: SalGenericDisplay::DispatchInternalEvent() (gendisp.cxx:91)
==18064==    by 0x16E2AA6F: GtkData::userEventFn(void*) (gtkdata.cxx:938)
==18064==    by 0x16E2AACA: call_userEventFn (gtkdata.cxx:948)
==18064==    by 0x3D5F047A54: g_main_context_dispatch (gmain.c:2715)
==18064==    by 0x3D5F047D87: g_main_context_iterate.isra.24 (gmain.c:3290)
==18064==    by 0x3D5F047E43: g_main_context_iteration (gmain.c:3351)
==18064==    by 0x16E29933: GtkData::Yield(bool, bool) (gtkdata.cxx:577)
==18064==    by 0x16E2D907: GtkInstance::Yield(bool, bool) (gtkinst.cxx:562)
==18064==    by 0x8FD1D0D: ImplYield(bool, bool) (svapp.cxx:422)
==18064==    by 0x8FCDD24: Application::Yield(bool) (svapp.cxx:456)
==18064==    by 0x8FCDCC5: Application::Execute() (svapp.cxx:401)
==18064==    by 0x4ED9249: desktop::Desktop::Main() (app.cxx:1736)
==18064==    by 0x8FDA475: ImplSVMain() (svmain.cxx:162)
==18064==    by 0x8FDA55E: SVMain() (svmain.cxx:198)
==18064==    by 0x4F1BFAD: soffice_main (sofficemain.cxx:82)
==18064==    by 0x400997: sal_main (main.c:48)
Comment 1 Commit Notification 2013-04-11 14:45:29 UTC
Caolan McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=60683b6de3f0ef0e9b22de5f5159086eb64e9f33

Resolves: fdo#63426 presentation wizard crashes



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 2 Caolán McNamara 2013-04-11 14:48:12 UTC
caolanm->markus: So I effectively reverted the fix for coverity#705698: fix memory leak of 13e8f68e82713cae2d081a236b260bda12aafa23 so you might want to revisit that fix. I couldn't quickly see what the right fix would be on inspecting the coverity report.