Various libraries in svtools/ and sfx2/ set include paths to subdirs of $(INCLUDE) like -I$(SRCDIR)/include/sfx2/. Since $(SRCDIR)/include/ is already in the include paths, the headers are reachable from there already. Removing the additional path and then fixing up the #include statements should improve build times possibly and make the location of the header more explicit.
Created attachment 78814 [details] remove extra include paths in svtools/ and sfx2/
Comment on attachment 78814 [details] remove extra include paths in svtools/ and sfx2/ This needs a bit of tweaking: the include statement should be removed completely, not replaced with a relative patch. Also there seem to be additional temporary file garbage in the dump?
Radu Ioan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1cbdcc31b8a921c508f2fdf09847f64d004a7faa fdo#63926 - remove extra include paths in svtools/ and sfx2/ The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Radu Ioan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=389bdc162415abff78971b1ce7c5d47482e1d37b fdo#63926 - remove extra include paths in svtools/ and sfx2/ The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=fa96ed925fc40e20aca58551414e5bc5d61a87bd Revert "fdo#63926 - remove extra include paths in svtools/ and sfx2/" The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=593a298dd3cf61781d0d069eaf2fa80a82eda502 Revert "fdo#63926 - remove extra include paths in svtools/ and sfx2/" The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
evidently the description is not clear, what needs to be done is to remove these lines: -I$(SRCDIR)/include/svtools/ and -I$(SRCDIR)/include/sfx2/ from svtools/Library_svt.mk sfx2/Library_sfx.mk sfx2/Library_qstart_gtk.mk and then fix up the includes everywhere so it builds again.
Comment on attachment 78814 [details] remove extra include paths in svtools/ and sfx2/ sorry, this patch is also wrong...
Marcos Paulo de Souza committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e95b076744da8911b2804501b418649a9147e3a9 fdo#63926: remove extra include paths in svtools/ and sfx2/ The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
This is fixed now in master
Migrating Whiteboard tags to Keywords: (EasyHack DifficultyBeginner SkillCpp ) [NinjaEdit]