Created attachment 78949 [details] Suggestion Windows is not aligned on Writer. OK on MSWord. Currently LibreOffice does not support Win32 IMR_QUERYCHARPOSITION request. http://listarchives.libreoffice.org/ja/discuss/msg01839.html IMR_QUERYCHARPOSITION is one of optional but fundamental requests issued from IMEs to application. This message is used to retrieve the positional information about positional information of composition characters drawn by the application. This information is critical for IMEs to align suggestion window with the composition text. Starting with Windows 8, built-in MSIME starts using suggestion UI. So it would be nice if LibreOffice can support IMR_QUERYCHARPOSITION like Microsoft Word.
Created attachment 78950 [details] Suggestion Windows is not aligned on Writer. OK on MSWord.
Created attachment 78951 [details] Proposed patch to support IMR_QUERYCHARPOSITION for Writer and Calc
If I should send this patch directly to gerrit.libreoffice.org, please let me know. Thanks,
Yes in general gerrit is best wrt. finding reviewers - on the other hand - this looks like a really sexy feature :-) I'd love to see it in 4.1 (feature freeze next week). Tor - a windows feature, any chance of a quick sanity check / review ? Nice work Yohei !
"quick"? Windows? no;)
In other words, if I start a build of master now, it will be ready by Monday. (I don't keep my noisy, power-hungry Windows box running outside work hours, and even then only when I am actually working on some Windows thing.)
Ok - I have a live windows build here, I'll cherry-pick, test-compile - if you glance at the code, lets get it in and see how it goes :-)
Thank you for the information. Here is the entry for Gerrit. https://gerrit.libreoffice.org/#/c/3849/
Hello Yohei BugZilla is very open, so moving to the Assigned state did not assign yourself to the bug. So I do it for you, assuming this was what you expected. And thanks for the patch :)
Wow, yes, that is what I intended. Thanks!
The gerrit patch was merged, so presumably this bug can be resolved.
Will ship in 4.1 - going into feature freeze in a week: https://wiki.documentfoundation.org/ReleasePlan/4.1 would be really great to have your nice screenshot in: https://wiki.documentfoundation.org/ReleaseNotes/4.1 with your name next to it - could you add it there ? :-) Thanks !
Sure. I'll do it after today's nightly build becomes available. Thank you for your assistance!
I just built the latest on Windows with this enhancement. I can confirm that this is working beautifully. Great work! :-)
Added a screenshot in https://wiki.documentfoundation.org/ReleaseNotes/4.1#Writer Thanks!