Download it now!
Bug 64406 - Missing Right Parens in Tools/Strings/Elimchar Function
Summary: Missing Right Parens in Tools/Strings/Elimchar Function
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: BASIC (show other bugs)
Version:
(earliest affected)
4.0.2.2 release
Hardware: All All
: medium normal
Assignee: Jorendc
URL:
Whiteboard: target:4.1.0 target:4.0.4
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-09 23:31 UTC by Ed
Modified: 2013-05-10 16:49 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed 2013-05-09 23:31:03 UTC
In LibreOffice 4.0.2.2, LibreOffice Macros & Dialogs/Tools/Strings/Elimchar function,   'BigString =' line is missing closing parens.

Copy of Function:

' Deletes out of a String 'BigString' all possible PartStrings, that are summed up
' in the Array 'ElimArray'
Function ElimChar(ByVal BigString as String, ElimArray() as String)
Dim i% ,n%
	For i = 0 to Ubound(ElimArray)
---->		BigString = DeleteStr(BigString,ElimArray(i)
	Next
	ElimChar = BigString
End Function
Comment 1 Jorendc 2013-05-10 09:50:44 UTC
Nice catch and thanks for reporting!
I'll take this easy one, and send a patch.

How did you saw that/was there some strange behavior (in that case there may be some bugs around, related to this not-closed parenthesis which we can mark as fixed now).

Kind regards,
Joren
Comment 2 Commit Notification 2013-05-10 11:48:21 UTC
Joren De Cuyper committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=fb889fa870badb051a48d648f722b7895c6f8896

Solve fdo#64406 Missing right closing parenthesis



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2013-05-10 12:13:42 UTC
Joren De Cuyper committed a patch related to this issue.
It has been pushed to "libreoffice-4-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=92fb9d8cbbf95f10aca244c408592c31e4127f6d&h=libreoffice-4-0

Solve fdo#64406 Missing right closing parenthesis


It will be available in LibreOffice 4.0.4.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 4 Ed 2013-05-10 16:29:57 UTC
(In reply to comment #1)
> Nice catch and thanks for reporting!
> I'll take this easy one, and send a patch.
> 
> How did you saw that/was there some strange behavior (in that case there may
> be some bugs around, related to this not-closed parenthesis which we can
> mark as fixed now).
> 
> Kind regards,
> Joren

I'm new to programming, except for some Fortran, Basic and DataEase many years ago.  While learning LibreOffice Basic, I was scrolling through the included functions and subroutines, and noticed the lacking parens.

Note: Because the functions and subroutines are included, detailed descriptions should be included with each, including describing the UNO objects called.  The comments currently attached are very sparse.  It would be even better if descriptions were included in Help, or documented in depth elsewhere, to make it easy for users to call the code, or learn it like me.  Examples of code are as important as the details on how to use each command.

And thanks for being so prompt.  I'm quite surprised by the amount of effort put into a free product.  I hope to be able to help soon - probably documenting macros, eh?
Ed
Comment 5 Jorendc 2013-05-10 16:49:30 UTC
(In reply to comment #4)
> I'm new to programming, except for some Fortran, Basic and DataEase many
> years ago.  While learning LibreOffice Basic, I was scrolling through the
> included functions and subroutines, and noticed the lacking parens.
Ooh, I see. Although 'just scrolling through code' it's still nice you saw that missing :-).
 
> Note: Because the functions and subroutines are included, detailed
> descriptions should be included with each, including describing the UNO
> objects called.  The comments currently attached are very sparse.  It would
> be even better if descriptions were included in Help, or documented in depth
> elsewhere, to make it easy for users to call the code, or learn it like me. 
> Examples of code are as important as the details on how to use each command.

I'm just a core QA (quality assurance) team member, not a developer :-) (at all :p). So feel free to help us document it!
 
> And thanks for being so prompt.  I'm quite surprised by the amount of effort
> put into a free product.  I hope to be able to help soon - probably
> documenting macros, eh?

Sure, that'll be nice. Very welcome!

I think emailing the documentation or development list will be the right place to get directions "how to document it etc". (http://www.libreoffice.org/get-help/mailing-lists/)

Kind regards,
Joren