Version: 188.8.131.52.alpha1+ Build ID: 35fdbea1a112c0f0bf8ea6e9003cf0e13b9cd88
Standard memory settings: 50 Mb memory, 5,2 object, 20 number of objects.
Inserting photo album slides, no matter the number of photos per slide.
With: 60 jpg images - 102 Mb ->no crash
With: 61 jpg images - 106 Mb ->crash
mariosv - do you mind describing the process to get this crash? Sorry not familiar with photo album so explicit steps will help us triage
I reproduced this using Windows 7 64bit when I inserted ~200 Images.
However, on Ubuntu it didn't crash.
@Joel: Just use the Photo Album to insert images (Impress->Insert->Image->Photo Album)
Thanks Samuel - I learn something new about LibreOffice every day
Created attachment 79440 [details]
pdf, steps up to crash.
New Presentation document.
Add - 61 jpg images.
I imagine this is an Out of Memory, so it would be interesting to get a re-test on e.g. a current windows daily build to see if the various graphic cache re-works have had any effect on this
** Please read this message in its entirety before responding **
To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.
There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.
If you have time, please do the following:
Test to see if the bug is still present on a currently supported version of LibreOffice
(5.0.5 or 5.1.0) https://www.libreoffice.org/download/
If the bug is present, please leave a comment that includes the version of LibreOffice and
your operating system, and any changes you see in the bug behavior
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave
a short comment that includes your version of LibreOffice and Operating System
Please DO NOT
Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not
appropriate in this case)
If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3)
2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword
Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa
Thank you for your help!
-- The LibreOffice QA Team This NEW Message was generated on: 2016-02-21
Cannot reproduce using
Build ID: fdc1bd89559ea5efe2b3f6aa45b5158fedaed587
CPU Threads: 8; OS Version: Windows 6.1; UI Render: default;
Probably solved with the size check for swapped in graphics (0ca0202a0994c0b7c99c366fd5cafd8a655df203). Still, get an endless loop in OLEObjCache which has a timer and seems all the time to check if it should unload someting. Will check if I can reproduce this...
Really strange - the office works, but is unresponsive - something consumes 100% of one CPU core...
Found out that EditEngines consume the time, their OnlineSpellTimer triggers all the time, never stops. Is a timeout of '1000' intended...? Changed to 10000, solves the problem.
Nonetheless, the app crashes on closing the document (RequestHandler::pGlobal destructor)...
OTOH too many outliners exist, this leads to the trace that currently for each inserted graphic a new DrawModel is created and not destoyed. Found a problem in SdPhotoAlbumDialog::createCaption where a SdrModel is created by using pDoc->AllocModel(), but never freed. Each SdrModel creates 4 SdrOutliners (SdrOutliners: 3 by model, 1 by Sd (mpInternalOutliner)). It is only used to construct a single SfxItemSet to set some attributes at the created CaptionShape. This again will lead to problems since the SfxItemSet/SfxItemPool which is used to hold the items is *not* from the same SdrModel that the SdrObject is in.
I would guess that not 'AllocModel()' was intended, but just getting the SdrModel from the existing document.
Error was added by ommit 070141b854c7731aa44ccf6ce446802ad8653697, 'tdf#64573: Add captions to Photo Album'. This bug also explains why the added caption looks so bad. Trying a solution...
BTW: Only happens when creating caoption objects is switched on (default). It is questionable why all is done using UNO API, except creation of the SDrCaptionObj's.
Okay, when using pDoc as SdrModel no extra SdrModels get created. Still had a crash, since CreatePresObj was used and the object was added to the slide (pSlide->InsertObject). PresObj's are already added at creation, so it was added double and gets deleted double -> crash.
Both problems are due to unlucky design, people programming have to know too much about PresObjs and SdrModels to use the internal tooling. SdrModel::AllocModel() should not exist, maybe a Clone that would make clear what happens. PresObjs should only be fetchable (GetPresObj is there) and are created on demand dependent of PageLayout, even a CreatePresObj(PRESOBJ_TITLE, ...) may return null if a layout is set that allows no PRESOBJ_TITLE. All bad traps...
Two errors corrected, patch on gerrit.
Need to rebase, conflicted with https://bugs.documentfoundation.org/show_bug.cgi?id=99450 where thankfully someone already found the double Insert...
Armin Le Grand committed a patch related to this issue.
It has been pushed to "master":
tdf#64654 create no extra SdrModels, do not insert PresObj
It will be available in 5.2.0.
The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.
Is this bug fixed?
If so, could you please close it as RESOLVED FIXED?
Works fine for me with:
Version: 184.108.40.206 (x64)
Build ID: 3c2231d4aa4c68281f28ad35a100c092cff84f5d
CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL;
Locale: es-ES (es_ES); Calc: group
No issue inserting more than 200 images at once.