Bug Hunting Session
Bug 64830 - RTL: Arabic languages spellcheck should be merged into one
Summary: RTL: Arabic languages spellcheck should be merged into one
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: BSA
Keywords:
Depends on:
Blocks: Spell-Checking RTL-Arabic
  Show dependency treegraph
 
Reported: 2013-05-21 16:23 UTC by Munzir Taha
Modified: 2019-10-14 15:23 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Munzir Taha 2013-05-21 16:23:23 UTC
Problem description: 
Having a list of Arabic ($country) is redundant. Unlike en_US and en_GB, the spell checking of the Arabic language doesn't depend on the country.

Steps to reproduce:
1. Tools - Options - Language Settings - Languages


Current behavior:
There is a list of: Arabic (Algeria), Arabic (Egypt), Arabic (Lebanon), Arabic (Oman), Arabic (Saudi Arabia), Arabic (Tunisia)

Expected behavior:
To have only one option: Arabic
              
Operating System: Linux (Other)
Version: 4.0.3.3 release
Comment 1 Khaled Hosny 2013-05-25 13:07:56 UTC
AFAIK, the spell dictionaries was duplicated per country because OpenOffice didn’t look for “ab” dictionary if it didn’t find “ab_CD” one. So we need to check is this still the case and fix that (but I’m might be tricky, IIRC for some locales such behaviour would be undesired). There is probably a bug for this somewhere in the OpenOffice issue tracker.
Comment 2 Khaled Hosny 2014-01-01 14:57:12 UTC
Eike, any pointers about the linked OOo issue, any chance that your language tags work help here?
Comment 3 Khaled Hosny 2014-01-01 19:53:03 UTC
I thought, naïvely, that may be I can try to use MsLangId::getPrimaryLanguage() as fallback.

First, SpellChecker::hasLocale() in lingucomponent/source/spellcheck/spell/sspellimp.cxx is never called (not by Writer at least), so whatever I do there does not matter.

What gets called, however, is SpellCheckerDispatcher::hasLocale() in linguistic/source/spelldsp.cxx (which took me a while to find going through all that convoluted UNO stuff), but passing the primary language to aSvcMap.find() there does not find anything, apparently the spell checker for "ar" is never registered or something, but I gave up at this point since the code on that file is too clever for me to grasp.
Comment 4 Joel Madero 2015-05-02 15:42:33 UTC Comment hidden (obsolete)
Comment 5 Khaled Hosny 2015-05-02 16:24:10 UTC
Still an issue.
Comment 6 QA Administrators 2016-09-20 09:38:19 UTC Comment hidden (obsolete)
Comment 7 Munzir Taha 2016-09-20 18:37:14 UTC
Still an issue
Comment 8 Erik Quaeghebeur 2017-02-19 19:40:01 UTC
This same issue affects many other languages for which putting their dictionaries into the ‘locale’ mold creates extra work, for example, French and Dutch, both languages that are mostly ‘standardized’ worldwide qua spelling. So perhaps make the bug title broader.
Comment 9 Khaled Hosny 2017-02-19 20:34:04 UTC
Code pointers from the mailing list https://lists.freedesktop.org/archives/libreoffice/2017-February/076982.html (mainly so that I do not forget where to find them).
Comment 10 QA Administrators 2018-10-13 03:14:26 UTC Comment hidden (obsolete)
Comment 11 Erik Quaeghebeur 2018-10-13 10:35:39 UTC
(In reply to QA Administrators from comment #10)
> If the bug is present, please leave a comment that includes the information
> from Help - About LibreOffice.
Still present in 6.0.6.2.
Comment 12 QA Administrators 2019-10-14 02:27:24 UTC Comment hidden (obsolete)
Comment 13 Erik Quaeghebeur 2019-10-14 15:23:18 UTC
(In reply to QA Administrators from comment #12)
> If the bug is present, please leave a comment that includes the information
> from Help - About LibreOffice.

Still present in 6.2.5.2.