Download it now!
Bug 65407 - extension gui sizing issue ...
Summary: extension gui sizing issue ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
4.1.0.0.beta1
Hardware: Other All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:4.1.0.0.beta2 target:4.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-05 10:03 UTC by Michael Meeks
Modified: 2013-06-05 12:34 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
picture (34.38 KB, image/png)
2013-06-05 10:03 UTC, Michael Meeks
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Meeks 2013-06-05 10:03:19 UTC
WE seem to get some overlapping text in the extension manager on master - perhaps some minimum size request mis-calculation ?

It looks like the version is not included in whatever width calculation is needed; or is this the result of my larger font-size and:

             <object class="deploymentgui-ExtBoxWithBtns" id="extensions">
                <property name="width_request">600</property>
                <property name="height_request">320</property>

:-) happy to fix it, but advice appreciated.
Comment 1 Michael Meeks 2013-06-05 10:03:44 UTC
Created attachment 80336 [details]
picture
Comment 2 Caolán McNamara 2013-06-05 11:36:15 UTC
If the text doesn't fit, then in that particular widget its supposed to be ellipsed according to the code, but isn't for some reason. So that's the major bug.

That widget itself isn't layout aware, its a complicated existing thing. I should probably set a size request in terms of approx_char_width * foo rather than a pixel size.
Comment 3 Commit Notification 2013-06-05 12:03:50 UTC
Caolan McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-4-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8cbb5ceaa788f2c3ca4326d85edba02d2d8cf06e&h=libreoffice-4-1

Resolves: fdo#65407 fix broken ellipse generation


It will be available in LibreOffice 4.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2013-06-05 12:04:08 UTC
Caolan McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=3cd7da2249fbf87fa35e6803013a2d51278f70c2

Resolves: fdo#65407 fix broken ellipse generation



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2013-06-05 12:33:34 UTC
Caolan McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-4-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=93a0b9aac9ce55bb6d04f00bb817bb1da1566838&h=libreoffice-4-1

Related: fdo#65407 set a default size related to font size rather than pixels


It will be available in LibreOffice 4.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2013-06-05 12:34:10 UTC
Caolan McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=65df76208a8ad5d7b6de22b7bcae14148271dc54

Related: fdo#65407 set a default size related to font size rather than pixels



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.