Bug 65931 - drop caps preview grows constantly
Summary: drop caps preview grows constantly
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.1.0.0.beta2
Hardware: All Linux (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:4.1.0.2 target:4.2.0
Keywords:
Depends on:
Blocks: mab4.1
  Show dependency treegraph
 
Reported: 2013-06-19 12:37 UTC by Caolán McNamara
Modified: 2013-06-20 09:35 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Caolán McNamara 2013-06-19 12:37:38 UTC
4-1 0c117a1b51e3319e4a554952ef07b9ebd7004b6

writer: format->paragraph->drop caps->display drop caps, click, unclick, click, etc. The drop cap in the preview grows each time and expands to silly sizes. It shouldn't change at all of course.
Comment 1 Caolán McNamara 2013-06-19 12:39:10 UTC
weirdness around mnLeading in sw/source/ui/chrdlg/drpcps.cxx
Comment 2 Caolán McNamara 2013-06-19 12:59:28 UTC
This presumably is the same sort of problem as bug 65132. Its only a preview in this case, but something has "changed" wrt leading.
Comment 3 Commit Notification 2013-06-19 13:08:16 UTC
Caolan McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-4-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=90f381f02336126e850c657dc62ae0d2cc7b33ca&h=libreoffice-4-1

Resolves: fdo#65931 why are we futzing with leading on the preview anyway


It will be available in LibreOffice 4.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2013-06-19 13:08:34 UTC
Caolan McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=cb1ec05a72d54d55c8a98778c56ee01197cf45f4

Resolves: fdo#65931 why are we futzing with leading on the preview anyway



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 5 Caolán McNamara 2013-06-19 13:12:36 UTC
these leading changes worry me greatly
Comment 6 ⁨خالد حسني⁩ 2013-06-19 13:44:22 UTC
I can reproduce this one, unlike bug 65132, so I’ll check what is going on.
Comment 7 ⁨خالد حسني⁩ 2013-06-19 23:47:15 UTC
The root bug should be fixed in http://cgit.freedesktop.org/libreoffice/core/commit/?id=22d23d52b0f65636df3a1cb8fada9bf7de77eb78
Comment 8 Caolán McNamara 2013-06-20 09:35:55 UTC
ah excellent, that was pretty much the biggest thing I was worrying about for 4-1 :-)