Bug 66246 - compile failure for Chinese developers
Summary: compile failure for Chinese developers
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
4.2.0.0.alpha0+ Master
Hardware: Other Windows (All)
: medium critical
Assignee: Not Assigned
URL:
Whiteboard: target:4.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-27 08:43 UTC by Michael Meeks
Modified: 2013-08-31 13:34 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Meeks 2013-06-27 08:43:33 UTC
I guess this is down to the 'current code page (936)' - ie. Simplified Chinese

 [build CXX] vcl/win/source/window/salmenu.cxx
C:/cygwin/home/core/vcl/win/source/window/keynames.cxx : warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent data loss
C:/cygwin/home/core/vcl/win/source/window/keynames.cxx(126) : error C2001: newline in constant
C:/cygwin/home/core/vcl/win/source/window/keynames.cxx(127) : error C2143: syntax error : missing '}' before '{'
C:/cygwin/home/core/vcl/win/source/window/keynames.cxx(127) : error C2143: syntax error : missing '}' before '{'
C:/cygwin/home/core/vcl/win/source/window/keynames.cxx(127) : error C2143: syntax error : missing ';' before '{'
C:/cygwin/home/core/vcl/win/source/window/keynames.cxx(127) : error C2447: '{' : missing function header (old-style formal list?)
C:/cygwin/home/core/vcl/win/source/window/keynames.cxx(127) : error C2059: syntax error : ','
C:/cygwin/home/core/vcl/win/source/window/keynames.cxx(128) : error C2143: syntax error : missing ';' before '{'
C:/cygwin/home/core/vcl/win/source/window/keynames.cxx(128) : error C2447: '{' : missing function header (old-style formal list?)
C:/cygwin/home/core/vcl/win/source/window/keynames.cxx(128) : error C2059: syntax error : ','
C:/cygwin/home/core/vcl/win/source/window/keynames.cxx(129) : error C2143: syntax error : missing ';' before '{'
C:/cygwin/home/core/vcl/win/source/window/keynames.cxx(129) : error C2447: '{' : missing function header (old-style formal list?)
C:/cygwin/home/core/vcl/win/source/window/keynames.cxx(129) : error C2059: syntax error : ','
C:/cygwin/home/core/vcl/win/source/window/keynames.cxx(130) : error C2143: syntax error : missing ';' before '{'
C:/cygwin/home/core/vcl/win/source/window/keynames.cxx(130) : error C2447: '{' : missing function header (old-style formal list?)
C:/cygwin/home/core/vcl/win/source/window/keynames.cxx(130) : error C2059: syntax error : ','
C:/cygwin/home/core/vcl/win/source/window/keynames.cxx(131) : error C2143: syntax error : missing ';' before '{'
C:/cygwin/home/core/vcl/win/source/window/keynames.cxx(131) : error C2447: '{' : missing function header (old-style formal list?)
C:/cygwin/home/core/vcl/win/source/window/keynames.cxx(131) : error C2001: newline in constant
make[1]: *** [C:/cygwin/home/core/workdir/wntmsci13.pro/CxxObject/vcl/win/source/window/keynames.o] Error 2
make[1]: *** Waiting for unfinished jobs....
make[1]: INTERNAL: Exiting with 2 jobserver tokens available; should be 4!

Presumably we should have those constants as hex / UTF8 ? or perhaps we want a UTF-8 byte pair at the beginning of the file ?
Comment 1 Don't use this account, use tml@iki.fi 2013-06-27 09:15:46 UTC
That file is jcorrius's baby and he is a better MSVC expert than I am. Does he have a bugzilla account?
Comment 2 Julien Nabet 2013-06-30 20:44:03 UTC
It seems that Isamu Mogi found an explanation + patch about this, see fdo#66395 in "See also"
Comment 3 Isamu Mogi 2013-07-31 04:00:58 UTC
Patch was uploaded to https://gerrit.libreoffice.org/#/c/4270/ . It is waiting for reviews.
Comment 4 Commit Notification 2013-07-31 08:38:15 UTC
Isamu Mogi committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ded871e9c1a69f640d6283ae6f79820689f0d612

fdo#66246 fdo#66395 BOM for MSVC with UTF-8 unfriendly codepage



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2013-07-31 09:46:41 UTC
Fridrich Å trba committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c7a8462b839f37712620fd2c236cfda026ec546d

Revert "fdo#66246 fdo#66395 BOM for MSVC with UTF-8 unfriendly codepage"



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 7 Michael Meeks 2013-08-03 09:02:00 UTC
Right - thanks to Isamu and Fridrich => closing.