Bug 66591 - Missing picture in Germanophone OLH under index certificate
Summary: Missing picture in Germanophone OLH under index certificate
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Documentation (show other bugs)
Version:
(earliest affected)
4.1.0.1 rc
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Andras Timar
URL:
Whiteboard: target:4.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-04 15:57 UTC by Thomas Hackert
Modified: 2015-10-14 20:49 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Hackert 2013-07-04 15:57:14 UTC
Hello @ll,
I hope, I have chose the right component, severity and the like. If not, feel free to change it adequate ... ;)

Description:
1. Open LO StartCenter
2. Open OLH (either by <F1> or "Help - LibreOffice Help"
3. Change to tab "Index"
4. Start typing "Certificate" and enter, when LO has autocompleted it
5. Look to the right side, scroll the help side down to the first table

In LO Version: 4.1.0.2.0 Build ID: 103a942746cfe346e87daab62acbd4268c38097 under Debian Testing AMD64 with installed Germanophone help- as well as langpack there is only a placeholder instead of a picture. The German text right to the image is
<quote>
Die Signatur ist ungültig.
</quote>
(roughly translated: The signature is invalid)

Sorry for the inconvenience
Thomas
Comment 1 Jean-Baptiste Faure 2013-07-13 20:24:52 UTC
Not restricted to DE version, I see the same problem with the French version under Ubuntu 12.04 with Version: 4.1.1.0.0+ (Build ID: 6180917f2d8280f643b14a69abdca79d91820f8)

Best regards. JBF
Comment 2 Jean-Baptiste Faure 2013-07-13 20:26:01 UTC
Same problem with the English version.
Comment 3 Thomas Hackert 2013-09-30 07:35:15 UTC
Hello Jean-Baptiste, *,
(In reply to comment #2)
> Same problem with the English version.

thanks for reproducing my bug :) I still have this problem with LO Version: 4.1.2.2 Build ID: 281b75f427729060b6446ddb3777b32f957a8fb under Debian Testing AMD64 and installed Germanophone lang- as well as helppack ... :( Do you think, I should add Andras to the CC or assign it to him? Or would it be better to ask on the QA ML?
Have a nice day
Thomas.
Comment 4 Jean-Baptiste Faure 2013-10-05 21:23:38 UTC
Hi Andras, possibly one for you.

Best regards. JBF
Comment 5 Commit Notification 2013-10-06 12:01:57 UTC
Andras Timar committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/help/commit/?id=a3bf6d8c872c363909e6173990fddcdd0e69d676

fdo#66591 missing image



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 6 Andras Timar 2013-10-06 12:03:38 UTC
I changed the image path in master and I re-added the deleted image in libreoffice-4-1 branch.
Comment 7 Commit Notification 2013-10-07 13:43:00 UTC
Andras Timar committed a patch related to this issue.
It has been pushed to "libreoffice-4-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d1eb6ef693bb9cfdb6a611e8c18592d276a6c4cf&h=libreoffice-4-1

fdo#66591 help needs this image


It will be available in LibreOffice 4.1.3.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 8 Jean-Baptiste Faure 2013-10-08 08:35:18 UTC
Hi Andras,
are you sure that adding this missing file is sufficient to fix the problem on LO 4.1 ? Indeed on my own build I still do not see this icon in the help. I checked that it is in my local repository, it's ok, the file has the date of 2013-10-07. I did a complete release build (make distclean, etc.), installed the new version and I do not find this image file in the tree /opt/libreoffice4.1. I guess it should be in /opt/libreoffice4.1/share/config/image.zip. But perhaps I am wrong.

Best regards. JBF
Comment 9 Andras Timar 2013-10-08 09:05:38 UTC
(In reply to comment #8)
You are right, I did not try, sorry. The image is not packed, when it is not used by the UI. I just wanted to avoid string change in help in stable branch. Instead of introducing horrific hacks into helpcontent2/CustomTarget_imagelist.mk or changing the image path in help, which triggers a translation update, I would like to leave this bug unfixed in libreoffice-4-1.
Comment 10 Jean-Baptiste Faure 2013-10-08 20:27:52 UTC
(In reply to comment #9)

I agree. Thank you.
JBF