Bug 67481 - "Insert->Sheet From File...": Default name should be file name if no sheet name available
Summary: "Insert->Sheet From File...": Default name should be file name if no sheet na...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
3.5.7.2 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Sheet
  Show dependency tree / graph
 
Reported: 2013-07-29 14:33 UTC by gero
Modified: 2017-07-15 20:14 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description gero 2013-07-29 14:33:06 UTC 
The process for "Insert->Sheet From File..." could be improved:

The default name of the new sheet should be based on the file name instead of
"Sheet1".
Comment 1 afonit 2013-08-02 02:31:54 UTC 

*** This bug has been marked as a duplicate of bug 67479 ***
Comment 2 gero 2013-08-04 19:55:25 UTC 
What makes you think this is a duplicate? Bug 67479 is about being able to *edit* the default name whereas this bug here is about making the default name *more meaningful*.
Comment 3 ign_christian 2013-08-05 02:24:54 UTC 
I think this function (insert 'new sheet' from file) is confusing, almost sure that what is reported on Bug 64502 will happen.
Comment 4 gero 2013-08-05 10:00:38 UTC 
Christian, I'm afraid I'm not following. What is the connection between a meaningful sheet name (this enhancement) and a bug causing an import to fail (bug 65402)?
Comment 5 gero 2013-08-05 10:01:31 UTC 
(Typo: bug 65402 --> bug 64502)
Comment 6 Joel Madero 2013-08-06 19:40:11 UTC 
@Gero - the inserted sheet is based on the sheet name of the file being inserted. I just inserted a sheet from a file called "Test.ods" the sheet name was "ThisIsTestSheet" - when I inserted it into my new document the sheet name was ThisIsTestSheet.

This is intuitive as we'd expect sheet names to be the same across multiple documents. Basing it off the file name isn't intuitive as you could have a file that has 50 sheets - what if you insert 2 or 3 sheets from the file? Each one gets the same name as it's part of the same file - much better for it to take the sheet name from the original document

Marking as WONTFIX. Thanks for reporting
Comment 7 gero 2013-08-06 20:03:28 UTC 
@Joel: Good point, I didn't think of the fact that you can also import files with defined sheets.

But I'm talking about importing formats that don't even have a notion of a sheet: CVS in particular. In this case there is no sheet name to reuse and the file name should be used instead.

Those cases should be handeled differently:
* If a sheet name exists, reuse the sheet name (as is now).
* If no sheet name exists, use the file name instead (w/o the suffix).
Comment 8 Joel Madero 2013-08-06 20:06:53 UTC 
In general reporters shouldn't set their bug to NEW - only to unconfirmed but in this case, I agree, reasonable request although implementation could get tricky. 

Clarified title a bit
Comment 9 gero 2013-08-06 20:15:25 UTC 
Thanks Joel.

Sorry about the protocol violation but I don't think the GUI offered 'unconfirmed' as an option.
Comment 10 Joel Madero 2013-08-06 20:19:55 UTC 
@gero - yeah sometime FDO acts funny - it's fine, I agree valid request. 

Thanks again for the report