Trying to open this file pegs the CPU and then potentially crashes. Excel 2007 opens the file very fast and does no have any issues.
Link to the big excel file: https://dl.dropboxusercontent.com/u/3371527/Temperatures%20June.xlsx
On pc Debian x86-64 with master sources updated today, I reproduced the hanging. I didn't wait for the crash but saw the memory consumption increase more and more.
I've adjusted the Importance settings according to this flowchart: https://wiki.documentfoundation.org/images/0/06/Prioritizing_Bugs_Flowchart.jpg
Still an issue in 4.1.1.2
The reported problem can still be reproduce on version 4.1.3.
Kohei: perhaps you might be interesting in this one since you're doing some refactoring/optimizing (at least, it seemed to me as a beotian :-) )
Hi, This is still a problem in version 4.2.1
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (4.4.2 or later) https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for your help! -- The LibreOffice QA Team This NEW Message was generated on: 2015-05-02
Yes. this bug still occurs on my machine as originally described. One CPU core is pegged at 100% and the application freezes. silviu@trusty:~$ apt-cache policy libreoffice libreoffice: Installed: 1:4.4.2~rc2-0ubuntu1~trusty1 Candidate: 1:4.4.2~rc2-0ubuntu1~trusty1 Version table: *** 1:4.4.2~rc2-0ubuntu1~trusty1 0 500 http://ppa.launchpad.net/libreoffice/ppa/ubuntu/ trusty/main amd64 Packages 100 /var/lib/dpkg/status 1:4.2.8-0ubuntu2 0 500 http://archive.ubuntu.com/ubuntu/ trusty-security/universe amd64 Packages 500 http://archive.ubuntu.com/ubuntu/ trusty-updates/universe amd64 Packages 1:4.2.3~rc3-0ubuntu2 0 500 http://archive.ubuntu.com/ubuntu/ trusty/universe amd64 Packages OS is Ubuntu 14.04.2 64bit
Hello, I can reproduce the issue on 4.4.3.2 for Fedora 22. I will look into it. Tobias
Hello Silviu, thank you for providing the test-data, and for your patience :-) While the fixes will probably not help with your problem, other users will profit! I have identified the performance bottlenecks and will work on resolving them. Just for the record: The bottlenecks I have found so far are: chart2uno.cxx: ScChart2DataSequence::getNumberFormatKeyByIndex() Here, the check for hidden rows eats a lot of time. Caching them should help. listener.cxx: SvtListener::EndListeningAll() cellsuno.cxx: ScLinkListener::EndListeningAll() Could be resolvable by offering a method to end listening of a bulk set of listeners ExplicitCategoriesProvider.cxx: lcl_fillDateCategories() The check for the date format takes a lot of time. A caching mechanism should resolve this too Tobias
All I can say is, thank you very much for looking into this :)
I have fixed the bug. I can open the file on my machine. The code is currently waiting for review. (https://gerrit.libreoffice.org/#/c/16320/5) The fix will be available in the next version.
Oh my! This is great news! When you say "next version" do you mean during the 4.x cycle or 5.x?
Silviu: for the moment the patch must be approved in master branch (= future 5.1.0). If ok, I suppose Tobias will cherry-pick it on 5.0 branch and perhaps on 4.4 branch.
@Julien - Sure. Let me know if you need help.
(In reply to Tobias Lippert from comment #16) > @Julien - Sure. Let me know if you need help. Oh, I read that wrong. I though you wanted to try to port the fixes. :-) I will port them after the fix has been reviewed and verified and write here how it went.
LO could open it finally up to 3.4.4. Since it was always slow, I wouldn't call it a regression.
Could somebody please have a look at the gerrit commits? They can be found here. https://gerrit.libreoffice.org/#/c/16315/4
Tobias Lippert committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b014150e64cdc23dfd999061bc210f0ad701f0a2 tdf#68016 Write fixture for current behaviour of SfxListener It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
There is still one patch missing. I will post an update as soon as it passes code review.
Tobias Lippert committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=431957118d7bbf96bf78e142df9decbcaff6475b fdo#68016 Speed up ScChartListenerCollection::EndListeningHiddenRange It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Tobias Lippert committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e355661fe6352c93305406330349b630735fd4cd fdo#68016 Add unittests for ScChartListenerCollection It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
There is still one commit waiting for review before the fix can be tested. https://gerrit.libreoffice.org/#/c/16485/
Tobias Lippert committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1979c48bf96bc1fd8f3558b6c9970935ddd79723 tdf#68016 Speed up ScChart2DataSequence by caching addresses It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
This bug should be fixed on the master branch. If someone could validate this, that would be great.
Hi Tobias, I'm testing Build ID: edf9fa4a37261202196e8873169151f376cfd33b Wow, it actually manages to open the file in reasonable time. The window still goes black (like the application froze). But this being said, it's just a *huge* improvement over any of the previous stable versions of LO. Switching between sheets with graphs on them still takes around 6-8 seconds the first time I switch to them. The good part is that subsequent switching between those sheets is actually very fast and responsive. I have uploaded a video here: https://www.youtube.com/watch?v=UQSOiOreLxw Thank you very much!
I forgot to ask. Do I need to open a separate bug report to address the performance?
(In reply to Silviu C. from comment #28) > I forgot to ask. Do I need to open a separate bug report to address the > performance? I think so, crash is different that perf problem.
(In reply to Silviu C. from comment #28) > I forgot to ask. Do I need to open a separate bug report to address the > performance? Hello Silviu, Great - thanks for the video :-) It's good to see that it is actually working on a machine other than mine. I have seen the strangest differences between computers. If it is not too much work, it would be good to create a new bug. The file opens (albeit slowly), and optimizing for performance is another task. Tobias
Ok, I created a new bug report here: https://bugs.documentfoundation.org/show_bug.cgi?id=93819 Thank you again for all the work you've done.
crash fixed according to comment 27 so RESOLVED FIXED the performance issue will be discussed in Bug 93819