Bug 68113 - [UI] [Autofilter] Selecting "Not empty" unchecks all entries
Summary: [UI] [Autofilter] Selecting "Not empty" unchecks all entries
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
3.6.6.2 release
Hardware: All All
: medium minor
Assignee: Balázs Varga
URL:
Whiteboard: target:7.2.0
Keywords:
Depends on:
Blocks: AutoFilter
  Show dependency treegraph
 
Reported: 2013-08-14 15:50 UTC by Mirosław Zalewski
Modified: 2021-06-03 18:23 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Simple file with autofilter enabled, for your convenience (8.34 KB, application/vnd.oasis.opendocument.spreadsheet)
2013-08-14 15:50 UTC, Mirosław Zalewski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mirosław Zalewski 2013-08-14 15:50:00 UTC
Created attachment 84062 [details]
Simple file with autofilter enabled, for your convenience

(Derived from Bug 57431)

Steps to reproduce
1. Open any spreadsheet document, create AutoFilter on some data (see attached file for example).
2. In any column, open AutoFilter pop-up window and select "Not empty".
3. Open AutoFilter pop-up window again on this column.

Result
All checkboxes (by values and "All") are unchecked.

Expected result
Since all values are visible, one might expect these checkboxes to be checked.

Reproduced under Debian testing, amd64. LO 4.0.4 from Debian repository and 3.6.6 and 4.1.0, both from TDF website. Therefore, starting with NEW.
Comment 1 Michel Rudelle 2013-08-21 17:11:40 UTC
Reproduced under Vista-32b:
Version 4.0.5.2 (Build ID: 5464147a081647a250913f19c0715bca595af2f)
Version: 4.1.0.4 Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace28
Comment 2 Kevin Suo 2014-11-10 06:55:17 UTC
I my opinion, this is the same issue as in Bug 65505 - FILTER: Auto filter checkbox missing for "empty" cells.

When you click "Not Empty", Calc is filtering out only the values "Not Empty", thus uncheck all others. "Not Empty" here has the same effect as a checkbox.

The "Not Empty" botton should be converted to a checkbox (as requested in bug 65505) in order to avoid many confusion.

Can this bug be marked as a duplicate of bug 65505? (I am adding SEE ALSO at this moment.
Comment 3 alister.hood 2014-11-10 22:30:06 UTC
Yes, if all these bugs are rolled into one, this should be included - it is impossible to visually represent "Not empty" without implementing an "empty" checkbox.
Comment 4 alister.hood 2014-11-10 22:49:17 UTC
Well, I suppose technically you could have "All" checked with a "-" instead of a tick (Maybe some platforms tick in grey rather than with a "-"), and everything else ticked with a tick.  But this isn't transparent - most users probably wouldn't realise what it meant.
Comment 5 QA Administrators 2015-12-20 16:18:04 UTC Comment hidden (obsolete)
Comment 6 QA Administrators 2017-01-03 19:49:58 UTC Comment hidden (obsolete)
Comment 7 Roman Kuznetsov 2019-02-03 19:16:18 UTC
still repro in

Версия: 6.3.0.0.alpha0+
ID сборки: 51af3179cf972809d6495c7d58033e069f647bbf
Потоков ЦП: 4; ОС:Linux 4.18; Отрисовка ИП: по умолчанию; VCL: kde5; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-02-01_00:15:00
Локаль: ru-RU (ru_RU.UTF-8); UI-Language: ru-RU
Calc: threaded
Comment 8 b. 2020-10-07 07:45:47 UTC
funny, 

it looks as if the checkbox for 'empty' (c#2) is recently added, if you click 'not empty' correctly all non empty values are displayed and the rows with empty cell in that column are hidden, ... but ... if you re-open the filter popup all checkboxes for all values are unchecked??, except that for 'empty', that's checked!!!  

upside-down world? wrong 'code reuse'???

ver. 7.1.0.0.a0+ 2020-10-04, tested without defined range, one column, range manually selected to not to stop at empty cell,
Comment 9 Commit Notification 2021-05-28 07:33:47 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/00e13be1c3dd45597237f805a06b3e8a74187125

tdf#68113 sc autofilter: fix not empty button unchecks all entries

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2021-05-31 11:15:05 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e8bba8229080f873b89b39551e924d1c8609fc07

Related tdf#68113 sc autofilter: clean-up for

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 BogdanB 2021-06-03 18:23:07 UTC
Thanks for fixing this, a very old bug.
It's ok now in
Version: 7.2.0.0.alpha1+ / LibreOffice Community
Build ID: f49e5902a3737c02fabf5bec23243ccb126426c4
CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded