Bug 69028 - finalized configuration items are editable on UI
Summary: finalized configuration items are editable on UI
Status: CLOSED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
4.2.0.0.alpha0+ Master
Hardware: Other All
: medium normal
Assignee: Stephan Bergmann
URL:
Whiteboard: target:4.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-06 11:27 UTC by Janos FARAGO
Modified: 2020-06-09 11:48 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Janos FARAGO 2013-09-06 11:27:22 UTC
Configuration items can be locked with the oor:finalized="true" attribute. In OpenOffice.org 3.2 such item is locked on the UI, i.e. the control is greyed out, and not editable. Sometimes a even a small yellow key icon is appearing next to the control, in order to show that the setting is locked. 

In LibreOffice, however, UI controls are not locked, the user can change them. 

== Example ==

Let's create share\registry\data\finalized.xcu with the following content:

<?xml version="1.0" encoding="UTF-8"?>
<oor:items xmlns:oor="http://openoffice.org/2001/registry" xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<item oor:path="/org.openoffice.UserProfile/Data"><prop oor:name="o" oor:finalized="true"><value>Example Corp.</value></prop></item>
</oor:items>

This sets and locks Tools - Options - LibreOffice - User Data - Company. When I open LibreOffice, I see Example Corp. and I can modify the edit box. Fortunately the modified setting is not saved. When I reopen the panel, Example Corp. is there. So this is only a UI glitch.

== Problem ==

User does not have visual feedback of locked settings. Iz used to work in OpenOffice.org, so it is a regression.
Comment 1 Commit Notification 2013-09-25 20:55:01 UTC
Stephan Bergmann committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=53e5fb9dc1e3d6aeee6acffebe93147e41515aef

fdo#69028 Set PropertyAttribute::READONLY for finalized configmgr props



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 2 SharonCrane 2020-06-09 11:10:57 UTC Comment hidden (spam)