Bug 69195 - Crash when delete a style in use
Summary: Crash when delete a style in use
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.1.1.2 release
Hardware: x86-64 (AMD64) Linux (All)
: medium major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 72462 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-09-10 19:07 UTC by Gabriel Saraiva
Modified: 2014-11-05 04:58 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Poposed patch (31.43 KB, patch)
2014-04-03 13:03 UTC, Mohamed-Ali BEN MANSOUR
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel Saraiva 2013-09-10 19:07:49 UTC
I was editing a file in Writer and creating my own styles. When I tried delete a style that was in use in some part of document, Writer crashed and closed.

How to repeat the problem: Create a style, apply it on a text then try to delete it without remove style from text.

:)

PORTUGUESE BRAZIL

Eu estava editando um arquivo no Writer e criando meus próprios estilos. Quando eu tentei excluir um estilo que estava em uso em alguma parte do documento, o Writer caiu e fechado.

Como repetir o problema: Criar um estilo, aplicá-lo em um texto, em seguida, tentar excluí-lo sem remover o estilo do texto.

:)
Comment 1 Jorendc 2013-10-12 15:38:33 UTC
I fail to reproduce this, tested using Linux Mint 15 x64 with LibreOffice Version: 4.1.1.2 Build ID: 7e4286b58adc75a14f6d83f53a03b6c11fa2903

@Gabriel: you mind creating a small test document so I can try to reproduce this behaviour? 

I did some work related to style-deletion, so I might have introduce this behaviour (but I have to reproduce it before I can fix it :) )

Kind regards,
Joren
Comment 2 Gabriel Saraiva 2013-10-12 20:46:39 UTC
(In reply to comment #0)
> I was editing a file in Writer and creating my own styles. When I tried
> delete a style that was in use in some part of document, Writer crashed and
> closed.
> 
> How to repeat the problem: Create a style, apply it on a text then try to
> delete it without remove style from text.
> 
> :)
> 
> PORTUGUESE BRAZIL
> 
> Eu estava editando um arquivo no Writer e criando meus próprios estilos.
> Quando eu tentei excluir um estilo que estava em uso em alguma parte do
> documento, o Writer caiu e fechado.
> 
> Como repetir o problema: Criar um estilo, aplicá-lo em um texto, em seguida,
> tentar excluí-lo sem remover o estilo do texto.
> 
> :)


I'm trying to reproduce here, but I think that bug is already solved. It is not happening anymore here.

I guess because my version of Libreoffice now is "Versão: 4.1.2.3 - Id. de compilação: 4.1.2.3 Arch Linux build-1". 

I think that is why is not happening more the bug.

What I can do to help?
Comment 3 Jorendc 2013-10-13 22:04:17 UTC
(In reply to comment #2)

> I'm trying to reproduce here, but I think that bug is already solved. It is
> not happening anymore here.

Not sure this is 'in the end' good or bad :), but for now I think that's good.
 
> I guess because my version of Libreoffice now is "Versão: 4.1.2.3 - Id. de
> compilação: 4.1.2.3 Arch Linux build-1". 
> 
> I think that is why is not happening more the bug.

Most probably the answer yes. The first 2 or 3 versions of LibreOffice 4.1 are still "for early adopters, home users and _non_ business critical editing" because in these versions there are still many bugfixes introduced in the launch of 4.1.
 
> What I can do to help?

Well, try to stay 'alert' and if you can reproduce it again (and it is consistent), you can reopen this bug report and hopefully we can verify and fix it right away :)!
For now I'll mark this bug as RESOLVED WORKSFORME. As said, feel free to reopen if it reappears.

Thanks for your feedback and time :)!

Kind regards,
Joren
Comment 4 Ryan Duan 2013-12-20 04:28:29 UTC
*** Bug 72462 has been marked as a duplicate of this bug. ***
Comment 5 Mohamed-Ali BEN MANSOUR 2014-03-28 10:09:34 UTC
In LO 4.1.4.2, i can't remove custom styles in Hierarchical view of styles list.
Sometimes it crashes when trying to do that in Calc.
Comment 6 Mohamed-Ali BEN MANSOUR 2014-03-31 07:21:18 UTC
Crash in Windows 7.
Comment 7 Mohamed-Ali BEN MANSOUR 2014-04-03 13:03:31 UTC
Created attachment 96844 [details]
Poposed patch

The issue is fixed in LO 4.2. I propose the attached patch for 4.1.4.2 version.
Comment 8 Mohamed-Ali BEN MANSOUR 2014-04-10 09:43:25 UTC
Here is the same patch in gerrit: https://gerrit.libreoffice.org/#/c/8917/
Comment 9 V Stuart Foote 2014-11-05 04:58:21 UTC
The crash issue of attempting to delete an in use style is resolved with suitable warning dialog and handling of residual text.

Issue of deletion from heirarchial list of styles has also been resolved, although limitation of only one-at-a-time.

Proposed patches against 4.1.4 were abandoned as too late in that stable branch.

Setting Resolved Worksforme