Bug 69772 - EDITING - table wizard not functional for Firebird embedded database
Summary: EDITING - table wizard not functional for Firebird embedded database
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
4.2.0.0.alpha0+ Master
Hardware: x86 (IA32) Linux (All)
: high blocker
Assignee: Lionel Elie Mamane
URL:
Whiteboard: target:4.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-24 20:58 UTC by Alex Thurgood
Modified: 2013-10-25 09:10 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Thurgood 2013-09-24 20:58:18 UTC
With master build after make clean, fresh pull of today 21:30 pm

1) Create a firebird embedded db via the db creation wizard.
2) Attempt to create a new table using the table wizard - nothing happens

In the console, I see :

java.lang.NullPointerException
	at com.sun.star.wizards.db.DBMetaData.StringsFromResultSet(DBMetaData.java:966)
	at com.sun.star.wizards.db.DBMetaData.getCatalogNames(DBMetaData.java:985)
	at com.sun.star.wizards.table.Finalizer.<init>(Finalizer.java:63)
	at com.sun.star.wizards.table.TableWizard.buildSteps(TableWizard.java:245)
	at com.sun.star.wizards.table.TableWizard.startTableWizard(TableWizard.java:363)
	at com.sun.star.wizards.table.CallTableWizard$TableWizardImplementation.trigger(CallTableWizard.java:82)
java.lang.NullPointerException
	at com.sun.star.wizards.db.DBMetaData.StringsFromResultSet(DBMetaData.java:966)
	at com.sun.star.wizards.db.DBMetaData.getCatalogNames(DBMetaData.java:985)
	at com.sun.star.wizards.table.Finalizer.<init>(Finalizer.java:63)
	at com.sun.star.wizards.table.TableWizard.buildSteps(TableWizard.java:245)
	at com.sun.star.wizards.table.TableWizard.startTableWizard(TableWizard.java:363)
	at com.sun.star.wizards.table.CallTableWizard$TableWizardImplementation.trigger(CallTableWizard.java:82)


Alex
Comment 1 Terrence Enger 2013-10-06 14:06:16 UTC
I see the same problem on Linux in master commit 95e95e0 fetched
2013-09-19, so setting status NEW.

Meanwhile I wonder if a report from a Win or Mac user, positive or
negaive, would get us closer to fixing the problem.

Terry.
Comment 2 Lionel Elie Mamane 2013-10-25 08:11:26 UTC
Many thanks to Julien Nabet for pointing me at the right code place, which is 80% of the bugfixing work, and providing a patch that worked around the underlying cause of this bug. That discussion took place on https://gerrit.libreoffice.org/6412
Comment 3 Commit Notification 2013-10-25 08:19:31 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a95ecd8b65ea2275a66f6694f0c09e3faaef4407

fdo#69772 make StringsFromResultSet more robust



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 4 Lionel Elie Mamane 2013-10-25 09:10:23 UTC
Lionel Mamane committed a patch related to this issue.
(but tagged it with the wrong bug number)
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d1fdaafd7c1c1ce3d89dda3bd745f9dd594d83ca

fdo#6412 firebird-sdbc DatabaseMetaData unimplemented getXXX: provide empty RS


The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.