Today I did an update to LibreOffice 4.1.4.2 on Windows 7. The bug is still there.
I did not get any response until today. Is there anything I can do to help? Additional info?

(In reply to comment #1)
> Today I did an update to LibreOffice 4.1.4.2 on Windows 7. The bug is still
> there.
> I did not get any response until today. Is there anything I can do to help?
> Additional info?

You did not attach the file with macro. Only the screenshot is there. Also, please explain, why it is a regression. Was it good in earlier releases? Which one is the last release, when it was good?

Here a little instuction for how to reproduce the bug.

- Please open the attached file "2.ott"
- Execute the macro
- Select in the "open" dialog file "3.odt"
- Check the result in column "Artikel" and compare it with the content from file "3.odt"

For the inspection, focus on the function "UebertrageQuellDaten", row "DestCell.String = Cell.String"

To your questions: This is not a regression, this is a bug. You get a different result on Linux and Windows, when you copy a text from one document to another. This problem never appeared on Linux or Mac.
The last working version on Windows was OO 1.1.4 (I know, it is been a while, but now I have to use the macro some times on Windows again). That is what I can tell you about running the macro on Windows. It is possible that a version in between on Windows was also good.

Created attachment 96719 [details]
File with macro 2.ott

Created attachment 96721 [details]
File 3.odt

I can confirm with Version: 4.3.2.2, win 7. No problem on linux.

Dear developers,

I am asking myself right now whether it does make a sense to report bugs. Please don't get me wrong. I don't reply to rant. It's been more then two years ago since I reported my bug. If you can't or don't want to fix this bug, that's OK. I can live with that. In this case please close this bug report, otherwise give me a sign.

Hello, unfortunatelly there is no predictable time when bugs will be fixed.

This regression was introduced before branch 4.4, thus it can't be bibisected with the current bibisect repositories. Changing keyword 'notBibisectable' to 'preBibisect'

No changes, the bug is still there.

Proposed patch: https://gerrit.libreoffice.org/c/core/+/132120

Unfortunately, it hits a single unit test on linux that shows a parsing error in the rtf import process. I will try to fix that as well.

After digging more into the code, I think this is not a bug. The string of the content will be retrieved in SwUnoCursorHelper::GetTextFromPam [1] using the system line ending (LINEEND_CRLF for Windows, LINEEND_CR for Linux) from a PaM. Assigning that string will then lead to different results, since they will be interpreted differently from either OS.

So Imho, you may parse the result of the string retrieval and check parse the contents inserting manual paragraphs or new lines.

[1]https://opengrok.libreoffice.org/xref/core/sw/source/core/unocore/unoobj.cxx?r=e072e414#128

(In reply to Andreas Heinisch from comment #16)
> After digging more into the code, I think this is not a bug. The string of
> the content will be retrieved in SwUnoCursorHelper::GetTextFromPam [1] using
> the system line ending (LINEEND_CRLF for Windows, LINEEND_CR for Linux) from
> a PaM. Assigning that string will then lead to different results, since they
> will be interpreted differently from either OS.
> 
> So Imho, you may parse the result of the string retrieval and check parse
> the contents inserting manual paragraphs or new lines.
> 
> [1]https://opengrok.libreoffice.org/xref/core/sw/source/core/unocore/unoobj.
> cxx?r=e072e414#128

Sorry but I don't agree with you. To me that is a bug. Please let's discuss it, and yes perhaps I am wrong and you are right.

The last working version on Windows was OO 1.1.4. So that means, it has worked on Linux, Windwos and MacOS.
The system line ending wasn't relevant.
Let me give you an example. I open a new LibreOffice Writer file on Linux and type two sentences. These sentences are in 2 lines with no extra line in between. Than I open this file on Windows and the document looks the same (no extra line between the 2 sentences). I can copy the first line and paste this line somewhere into the document. I don't see any extra line. That is how it suppose to work.
So the command "DestCell.String = SourceCell.String" should do it the same way.
What do you think?

@Mike what do you think about this problem?

(In reply to Andreas Heinisch from comment #18)

As I mentioned in https://gerrit.libreoffice.org/c/core/+/132120, I see how it's logical that getString should be symmetrical to setString (or whatever the underlying functions are called). So if getString uses code to use system-specific line ends, then setString should use the same conventions.

I see also how this potential change could likely cause regressions - we may have many places that rely on specific asymmetrical behavior of existing code. The current state is inconsistent anyway - the "good" situation on Linux is already not good: the paragraphs got converted into line breaks. Using system-dependent line ends, combined with the internal difference between paragraphs and line breaks, without a uniform convention like "paragraphs get represented as CR, and line breaks as LF, regardless of system", gives such a mess.

(In reply to bugs.kde.attila from comment #17)
> The last working version on Windows was OO 1.1.4. So that means, it has
> worked on Linux, Windwos and MacOS.

Of course, it would be interesting to see what was the result back then - was it always converting paragraphs into line breaks, too? Regardless, as said, the state on Linux is already a bug. I'd think that copying text by using String property should not be used, or should be used in a paragraph iterator (which is how the macro should be changed, but not a solution of this problem per se). Even if we suddenly decided to break everything by settling on "this character will mean paragraph, and this line break", we would still have multiple other things that would "looks different" - like not copying fields as fields, or footnotes, etc.

(In reply to bugs.kde.attila from comment #17)
> Let me give you an example. I open a new LibreOffice Writer file on Linux
> and type two sentences. These sentences are in 2 lines with no extra line in
> between. Than I open this file on Windows and the document looks the same
> (no extra line between the 2 sentences). I can copy the first line and paste
> this line somewhere into the document. I don't see any extra line. That is
> how it suppose to work.
> So the command "DestCell.String = SourceCell.String" should do it the same
> way.

Writer documents are not plain text. They include *lots* or metadata to store everything that document consists of: paragraphs, characters and their formatting, images, links, whatever. That's why the format it uses is so complex, being a ZIP package with multiple XMLs and binaries that are engineered to keep it all; and you will possibly have hard time trying to read the text using a plain text editor.

OTOH, when you use String property, you *convert* the data into a plain text. And that conversion is simply the same as would happen if you saved the text to a TXT file, which inherently is unable to keep it all properly. That inability is why Writer doesn't use TXT as its native file format after all.

So the reasoning "ODT opens consistently on any platform, thus plain text should be just as portable" is itself wrong.

Dear bugs.kde.attila,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug