Bug 70159 - Comments bar on Ruler Very Faint
Summary: Comments bar on Ruler Very Faint
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.1.1.2 release
Hardware: All All
: medium normal
Assignee: Jorendc
URL:
Whiteboard: target:4.3.0
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-05 06:02 UTC by Kumāra
Modified: 2014-02-02 14:21 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments
faint comments bar (1.33 KB, image/png)
2013-10-05 06:02 UTC, Kumāra
Details
Before patch (82.29 KB, image/png)
2014-01-31 14:11 UTC, Jorendc
Details
after patch (82.26 KB, image/png)
2014-01-31 14:11 UTC, Jorendc
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kumāra 2013-10-05 06:02:50 UTC
Created attachment 87149 [details]
faint comments bar

Enhancement made at https://bugs.freedesktop.org/show_bug.cgi?id=38246
does not appear as advertised on https://wiki.documentfoundation.org/images/b/b2/Commentsrulerbutton.png
in Windows version. See attached.
Comment 1 Jorendc 2014-01-31 14:03:06 UTC
Taking
Comment 2 Jorendc 2014-01-31 14:11:18 UTC
Created attachment 93141 [details]
Before patch

send a patch for review: https://gerrit.libreoffice.org/#/c/7768/
Comment 3 Jorendc 2014-01-31 14:11:32 UTC
Created attachment 93142 [details]
after patch
Comment 4 Kumāra 2014-02-01 03:31:31 UTC
(In reply to comment #3)
> Created attachment 93142 [details]
> after patch

Definitely better. Thanks, Jorendc. So it's now of the same shade as the margin section of the ruler?
Comment 5 Jorendc 2014-02-01 09:04:51 UTC
correct. Or that's at least what I was trying to do :). 

kind regards,
Joren
Comment 6 Commit Notification 2014-02-02 14:19:50 UTC
Joren De Cuyper committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=3fa5787df6c40625be12c20fd8b59374e7f538f0

fdo#70159 Comments label: Use darker color when not highlighted



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.