Bug 70268 - FILEOPEN: a possible defect in accessing an embedded link to a site that requires authentication
Summary: FILEOPEN: a possible defect in accessing an embedded link to a site that requ...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.1.2.3 release
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: BSA
Keywords: security
Depends on:
Blocks:
 
Reported: 2013-10-08 06:18 UTC by GAJ
Modified: 2015-01-23 20:03 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Scanned document from OCR (4.50 KB, application/zip)
2015-01-13 10:33 UTC, Chris Kjølbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description GAJ 2013-10-08 06:18:18 UTC
Problem description: 
Opening a document containing a link to figure from a site that requires authentication crash / fail to load LibreOffice. 
I have observed this for LO version 4.1.2 running under Win7, but I presume this will also happen under other OSs (e.g. Ubuntu Linux) too:

Steps to reproduce:
1. make new document in writer
2. login to a (secure) website, select a figure and, copy this using (right click, copy) and insert (paste) this figure into the writer document. This will create a link to the figure (and will not copoy and paste the figure as such, which one might expect...). At this stage the figure is displayed correctly.
3. save the writer document in some format (odt, doc, docx) and close Writer.
4. logout from the site the figure was copied from.
5. now use explorer to open the saved document: LibreOffice (writer) will not open or 'hang', probably it is unable to load the figure.


Current behavior:
I expected the figure itself to be copied into the writer document, but without any indication or warning, a link was pasted instead. While logged in to the website it was copied from, the figure is displayed correctly in writer.
After saving the writer document and logging out from the website the figure was copied from, LibreOffice is unable to open the document with the link (LO will not open, hangs)

Expected behavior:
While copying the figure into the writer document, the user should be at least informed that only a link is going to be pasted. In my opinion it would be better to present the option to choose between a link and the figure itself to be pasted (although I do see that this might be a bit too confusing for an occasional user / layman). 
After saving the document with the link, logging out and now trying to opne the document containing the link, LO should open the document and come up with the message that it cannot access the figure that the link points to, and not 'hang'. 

Operating System: Windows 7
Version: 4.1.2.3 rc
Comment 1 Jean-Baptiste Faure 2013-11-23 23:19:17 UTC
The copy button proposes 2 choices, html and bitmap. I did not have problem with bitmap. Did you tried the second option?

Best regards. JBF
Comment 2 GAJ 2013-11-25 10:12:51 UTC
(In reply to comment #1)
> The copy button proposes 2 choices, html and bitmap. I did not have problem
> with bitmap. Did you tried the second option?
> 
> Best regards. JBF

Dear JBF,

It took me some before I realized what you mean, but I think I get it now:

When I go to a website, copy an image (select with a right mouseclick and then copy image), and then in LO perform a 'Paste Special' (Ctrl-Shift-V), I get the option to paste as bitmap. This is indeed what I was looking for, now the actual image is pasted, and not just a link. This will prevent LO from crashing while trying to display an image following a link to a site that requires authentication, so problem solved for me.

However... why is this (pasting the actual image) not the default behavior in LO (instead of pasting a link??) Similar problems with LO not displaying an image in a saved document will occur when the user is trying to open this when offline.

PLease think about this, because the current default behavior is absolutely not intuitive to me (and probably not to 99% of other LO users)

Thanks in advance for your efforts and reply to this suggestion,

GAJ
Comment 3 Jean-Baptiste Faure 2014-02-13 20:22:44 UTC
Set to NEW without a comment, so probably an error. Set back to unconfirmed.

Please add a comment if you want to change the status of this bug report.

Thank you for your understanding.

Best regards. JBF
Comment 4 Chris Kjølbo 2015-01-13 10:33:47 UTC
Created attachment 112159 [details]
Scanned document from OCR

cannot import says corrupted file. says file is corrupt
Comment 5 Robinson Tryon (qubit) 2015-01-15 08:23:09 UTC
(In reply to Chris Kjølbo from comment #4)
> Created attachment 112159 [details]
> Scanned document from OCR
> 
> cannot import says corrupted file. says file is corrupt

Chris: Is this attachment related to the bug report? The mime-type says application/zip, but the file extension is .docx. Regardless of whether that file belongs on this bug report, something isn't quite right.
Comment 6 Robinson Tryon (qubit) 2015-01-15 08:25:43 UTC
(In reply to GAJ from comment #0)
> Problem description: 
> Opening a document containing a link to figure from a site that requires
> authentication crash / fail to load LibreOffice. 

That sounds pretty serious.

> I have observed this for LO version 4.1.2 running under Win7, but I presume
> this will also happen under other OSs (e.g. Ubuntu Linux) too:

Great, I test on Ubuntu most of the time.

Please attach a test document to this bug report along with some repro instructions (which sound like they'll be pretty short:
(1) Open the attached document
(2) Watch it hang :-)

Status -> NEEDINFO

Please change status back to UNCONFIRMED after you upload the test document and leave a comment w/notes. Thanks!
Comment 7 GAJ 2015-01-23 10:48:37 UTC
(In reply to Robinson Tryon (qubit) from comment #6)
> (In reply to GAJ from comment #0)
> > Problem description: 
> > Opening a document containing a link to figure from a site that requires
> > authentication crash / fail to load LibreOffice. 
> 
> That sounds pretty serious.
> 
> > I have observed this for LO version 4.1.2 running under Win7, but I presume
> > this will also happen under other OSs (e.g. Ubuntu Linux) too:
> 
> Great, I test on Ubuntu most of the time.
> 
> Please attach a test document to this bug report along with some repro
> instructions (which sound like they'll be pretty short:
> (1) Open the attached document
> (2) Watch it hang :-)
> 
> Status -> NEEDINFO
> 
> Please change status back to UNCONFIRMED after you upload the test document
> and leave a comment w/notes. Thanks!

Robinson,

I would like to let you know that the original report (valid 2013-10-08, for LO version 4.1.2 under Win7 and Ubuntu):

"opening a document containing alink to a figure from a site that requires crash / fail to load LibreOffice" 

is no longer an issue for me (now running LO 4.3.5, both under Win7 and Ubuntu 14.04).

Copying a figure (from a site that requires authentication) and pasting (ctrl-V) it into a Writer document, now introduces the actual picture in bitmap format by default (this used to be html-link to the picture, but this behaviour apparently has been changed). This change prevents introduction of 'unreachable' links when using this new default settings, which is the behaviour of choice.

In addition, when pasting a figure in a Writer document as html-link from a site that needs authentication, the image is not at all displayed in the document, but an empty frame containg the link to the picture is shown.
Documents containing such links can be saved and opened in LO, without any issues (no crashes as described in the original report).

GAJ
Comment 8 Robinson Tryon (qubit) 2015-01-23 20:03:46 UTC
(In reply to GAJ from comment #7)
> I would like to let you know that the original report...
> is no longer an issue for me
> [etc..]

Great!

Status -> RESOLVED WORKSFORME