Bug 70681 - reserved identifier violation
Summary: reserved identifier violation
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: sdk (show other bugs)
(earliest affected) release
Hardware: All All
: medium normal
Assignee: Thomas Arnhold
Whiteboard: target:4.2.0 target:4.3.0
Depends on:
Reported: 2013-10-20 17:09 UTC by Markus Elfring
Modified: 2014-05-15 12:56 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Julien Nabet 2014-02-10 21:35:18 UTC
Fixed from 4.2 branch with:
- http://cgit.freedesktop.org/libreoffice/core/commit/?id=29c0fdc6457243e7b7262b4db86c82b23a7ee0f1
- http://cgit.freedesktop.org/libreoffice/core/commit/?id=0bd7f12d41567842b1e31514e1d84340d90f5b42

Thomas: I assigned this bugtracker to you since you made the job! :-)
Comment 2 Markus Elfring 2014-02-11 10:06:04 UTC
(In reply to comment #1)

Thanks for your source code improvement.

Can the script "fixincludeguards.sh" be eventually reused for other software?
Comment 3 Markus Elfring 2014-02-16 07:58:33 UTC
(In reply to comment #1)

Do any more include guards need similar corrections?
Does a previous commit indicate further update candidates?
Comment 4 Thomas Arnhold 2014-04-24 10:17:54 UTC
Markus, you're right. This is a work in progress thing.

And yes, some guards of 8fc6905674142c226a117a97a08cf0b24c9d4fc1 have to be corrected. This can simply be done by running fixincludeguards.sh on the appropriate files (on linux).

And of course, you can reuse this script! :)
Comment 5 Commit Notification 2014-05-15 12:52:11 UTC
Thomas Arnhold committed a patch related to this issue.
It has been pushed to "master":


Resolves fdo#70681: fixincludeguards.pl: all that's left

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.
Comment 6 Thomas Arnhold 2014-05-15 12:56:51 UTC
Most of the stuff is fixed now. There are some candidates and conflicts left, but that is work in progress. The majority of the headers are fixed now.

Many headers don't have include guards indeed. You could use fixincludeguards.pl to identify them. Just in case you want to do some improvements :)