Bug 71057 - Missing redraw - Shadow from comments not removed (Win only)
Summary: Missing redraw - Shadow from comments not removed (Win only)
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
3.6.0.4 release
Hardware: x86-64 (AMD64) Windows (All)
: medium trivial
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: preBibisect, regression
: 113297 (view as bug list)
Depends on:
Blocks: Calc-Comments
  Show dependency treegraph
 
Reported: 2013-10-30 16:16 UTC by Peter H. Rankin Hansen
Modified: 2019-02-28 20:28 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
The comment shown (5.34 KB, image/png)
2013-11-03 14:28 UTC, Peter H. Rankin Hansen
Details
The comment shadow after moving the mouse away (3.87 KB, image/png)
2013-11-03 14:29 UTC, Peter H. Rankin Hansen
Details
Navigating into the shadow (2.53 KB, image/png)
2013-11-03 14:32 UTC, Peter H. Rankin Hansen
Details
test case (16.00 KB, application/vnd.ms-excel)
2014-02-16 12:38 UTC, tommy27
Details
Another Testcase (12.50 KB, application/vnd.oasis.opendocument.spreadsheet)
2014-05-23 19:22 UTC, christophe.jaillet
Details
Another screenshot (40.09 KB, image/jpeg)
2014-05-23 19:22 UTC, christophe.jaillet
Details
Screendump for comment 14, comments left visible (7.76 KB, image/gif)
2014-06-29 14:57 UTC, Peter H. Rankin Hansen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Peter H. Rankin Hansen 2013-10-30 16:16:24 UTC
When a cell comment has been shown because the red dot was "mouse-overed", not all cells the comment was overlapping are redrawn correctly, as part of the shadow (usually the bottom) for multi line comments may be left in place.

This seems to happen only for overlapped cells BELOW the one which contains the comment.

The problem has persisted for at least two years by now. At that time, it was most shadows, not just those below, so some improvement has been seen ;o)
Comment 1 bfoman (inactive) 2013-11-03 13:20:19 UTC
Could you please provide a screenshot of this error?
Comment 2 Peter H. Rankin Hansen 2013-11-03 14:28:38 UTC
Created attachment 88561 [details]
The comment shown
Comment 3 Peter H. Rankin Hansen 2013-11-03 14:29:33 UTC
Created attachment 88562 [details]
The comment shadow after moving the mouse away
Comment 4 Peter H. Rankin Hansen 2013-11-03 14:32:19 UTC
Created attachment 88563 [details]
Navigating into the shadow

This should illustrate the shadow error quite well.
Comment 5 Peter H. Rankin Hansen 2013-11-03 14:33:37 UTC
Done. Good hunting ;o)
Comment 6 tommy27 2014-02-15 17:38:58 UTC
would you please attach a test .ods file where you can reproduce this issue?
Comment 7 Peter H. Rankin Hansen 2014-02-16 10:55:14 UTC
I've sent the file privately
Comment 8 tommy27 2014-02-16 12:38:36 UTC
Created attachment 94157 [details]
test case

removed sensible informations from the file you sent me privately.
bug is reproducible from LibO 3.6.0 to 4.3alpha
not reproducible in LibO 3.5.7, hence regression of the 3.6.x branch
Comment 9 tommy27 2014-02-16 12:40:01 UTC
set status NEW. updated version field. added regression keyword.
added Calc expert to CC list.
Comment 10 christophe.jaillet 2014-05-23 19:21:23 UTC
Same problem exist in 4.2.0.4 and 4.3.0.0Beta1
New screenshot attached
Comment 11 christophe.jaillet 2014-05-23 19:22:03 UTC
Created attachment 99674 [details]
Another Testcase
Comment 12 christophe.jaillet 2014-05-23 19:22:35 UTC
Created attachment 99675 [details]
Another screenshot
Comment 13 christophe.jaillet 2014-05-23 19:25:04 UTC
Moreover, I have made some test on Ubuntu (14.04 in a WM) and on Windows 7 64 bits with the *same* file.
The issue only occured on Windows.
Comment 14 Peter H. Rankin Hansen 2014-06-29 14:53:36 UTC
Version 4.2.5.2 is even worse. If I mouse over the red dot for a comment, the entire comment and it's arrow will be left on screen, until you navigate into the cells it covers - and then only the relevant cell will be redrawn, leaving the rest of the comment visible. Scrolling the page will remove the comments.

I have a partial screendump with four visible comments.
Comment 15 Peter H. Rankin Hansen 2014-06-29 14:57:15 UTC
Created attachment 101977 [details]
Screendump for comment 14, comments left visible
Comment 16 steve -_- 2015-06-30 06:51:54 UTC
Could not reproduce on OS X with LO 5.1 nightly.

Setting to NEEDINFO. Does this persist with the latest nightly build?
http://dev-builds.libreoffice.org/daily/master/

After providing the requested info, please reset this bug to UNCONFIRMED (should it be persisting) or WORKSFORME (should it be solved with a newer LO version).
Comment 17 tommy27 2015-06-30 07:17:11 UTC
@steve
it's a Windows only bug
Comment 18 steve -_- 2015-06-30 08:12:03 UTC
Yep, would be great to have it retested.
Comment 19 tommy27 2015-06-30 18:56:34 UTC
retested under Win8.1x64

bug still present in LibO  5.1.0.0.alpha1+
Build ID: df7595a5f5871f8343e4ee3869ad153e3ae4a7f3
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-06-25_14:29:31
Locale: en-US (it_IT)

adding bibisectRequest in the whiteboard
the issue started in 3.6.x see comment 8
Comment 20 tommy27 2015-06-30 18:57:33 UTC
opppsss... sorry I forgot that Windows only bugs are not bibisectable...
Comment 21 rebelxt 2016-02-20 20:13:32 UTC
This also reproduces in Linux. See bug 73287.
Comment 22 Xisco Faulí 2016-09-13 11:28:53 UTC
Adding keyword 'preBisect' as this regression was introduced before branch 4.4 and therefore it can't be bibisected as there's no bibisect repository for this branch.
Comment 23 Daniel 2017-10-06 15:09:06 UTC
any progress about this? Still present in LO 5.4.2
Comment 24 Buovjaga 2017-11-07 15:39:44 UTC
*** Bug 113297 has been marked as a duplicate of this bug. ***
Comment 25 QA Administrators 2018-11-11 03:46:53 UTC Comment hidden (obsolete)
Comment 26 Roman Kuznetsov 2018-11-11 15:52:56 UTC
still rero for xls from attach in

Version: 6.2.0.0.alpha1+ (x64)
Build ID: 0b2d153f58c83fb289c96b348631e44e553b1a9a
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2018-11-02_21:11:48
Locale: ru-RU (ru_RU); Calc: threaded

but i can't repro it in ODS from attach
Comment 27 christophe.jaillet 2019-02-28 20:28:18 UTC
The issue seems to be less important in 6.2.0.3 (x86 - Windows 10)

On my system, the shadow issue only affects the upper border (previously there were also some issue with the right border)

When the shadow issue is visible, it is a very thin line now, much less visible than before.

Finally, at some zoom level, there is no issue at all. (but I don't remember if it was already the case before)


I've not been able to reproduce the issue with either of the 2 attached test-cases.
If needed I can provide a new one with the effect described above.