Bug 71853 - Page orientation imported incorrectly with (particular) DOCX file
Summary: Page orientation imported incorrectly with (particular) DOCX file
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.2.0.0.alpha1
Hardware: Other All
: medium normal
Assignee: Miklos Vajna
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2013-11-20 20:45 UTC by Jorendc
Modified: 2014-02-24 09:27 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jorendc 2013-11-20 20:45:49 UTC
How to reproduce:
* Download attachment of Bug 71809 (https://bugs.freedesktop.org/attachment.cgi?id=89487)
* Open it using master 4.2 version

Behavior: .doc file is imported with page orientation 'portrait' (Format > Page... > tab 'Page'). The correct orientation is 'landscape'.

Tested using Mac OSX 10.9 with LibreOffice Version: 4.2.0.0.alpha1+
Build ID: 9c45345a680f7444df251f9403c7d56572380f21
TinderBox: MacOSX-x86@49-TDF, Branch:master, Time: 2013-11-18_12:43:03

NOT reproducible using Mac OSX 10.9 with LibreOffice Version: 4.1.3.2
Build ID: 70feb7d99726f064edab4605a8ab840c50ec57a . In this version the page orientation is correctly imported.

So: regression
Comment 1 Arnaud Versini 2013-11-20 20:49:16 UTC
Confirmed on Opensuse 64 13.1 with 46dbc13169a9b97d3f8ac310ac35d5f51eea7de6
Comment 2 Michael Stahl (allotropia) 2013-12-18 17:30:09 UTC
regression in LO 4.1.4.2, worked in 4.1.3.2/

the file is not WW8 but DOCX, regression from:

commit d41fc60d4443e3ff22ac3ef0e56cb9131cd49cc9
Author:     Miklos Vajna <vmiklos@collabora.co.uk>
AuthorDate: Tue Oct 1 16:57:56 2013 +0200

    bnc#779620 DOCX import: try harder to convert floating tables to text frames
    
    Since 78d1f1c2835b9fae0f91ed771fc1d594c7817502, we convert floating
    tables to text frames only in case it's possible that there will be
    wrapping, to give better results for multi-page tables, which are
    multi-page, and technically floating ones, but that has no effect on the
    layout.
    
    The problem was that we try to do this decision too early, effectively
    the page width and margins were counted from the default letter size,
    instead of the actual values, which did not arrive at the time of the
    decision. Fix this by moving this logic at the section end.
Comment 3 Tamás Zolnai 2014-02-24 09:27:12 UTC
It is resolved as a side effect of the commit:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=e5fd7c2dacf3c128cdc62622e736ce8abbc578a5

It is pushed to all branches, see:
https://bugs.freedesktop.org/show_bug.cgi?id=74357