Bug 71991 - FORMATTING: arrow end default sizes incoherent with "Synchronize end" checked by default
Summary: FORMATTING: arrow end default sizes incoherent with "Synchronize end" checked...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.1.3.2 release
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Shapes-Line Arrow_Style
  Show dependency tree / graph
 
Reported: 2013-11-25 14:11 UTC by Jérôme Borme
Modified: 2022-11-27 18:15 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jérôme Borme 2013-11-25 14:11:42 UTC 
Steps to reproduce:
1. Open a new Presentation document.
2. Click the arrow tool and draw an arrow (say, from left to right)
3. Go to the arrow style drop list and select the style "Arrow" for the left part of the arrow.

Result: arrow is pointing in two sides (as expected), but size of the extremities are not the same, which is generally unwanted in a presentation and obliges the user to edit the properties to set the sizes of the two extremities to the same value.

Worse: now right-click on the arrow and select "Line" to edit line properties. You can see that although "Synchronize ends" is checked, the two sizes are indeed different. The right arrow is set to 0.3 mm, while the left part is set to 0.2 mm. If you press any of these sizes to change one of them, the other one follows, just like it should. The initial values of 0.2 and 0.3 are incoherent as they do not meet the basic idea of synchronizing the ends (which is checked by default).

Also bad: if you just draw a simple arrow and edit the properties, you can see that the "synchronize ends" is checked, although it is obvious that the arrow does not have synchronized ends (the left end has a line, the right end an arrow). And indeed the sizes are set to 0.2 and 0.3.
Comment 1 sophie 2013-11-25 15:14:33 UTC 
(In reply to comment #0)
> Steps to reproduce:
> 1. Open a new Presentation document.
> 2. Click the arrow tool and draw an arrow (say, from left to right)
> 3. Go to the arrow style drop list and select the style "Arrow" for the left
> part of the arrow.
> 
> Result: arrow is pointing in two sides (as expected), but size of the
> extremities are not the same, which is generally unwanted in a presentation
> and obliges the user to edit the properties to set the sizes of the two
> extremities to the same value.

I can reproduce that and agree that it's not optimal.
> 
> Worse: now right-click on the arrow and select "Line" to edit line
> properties. You can see that although "Synchronize ends" is checked, the two
> sizes are indeed different. The right arrow is set to 0.3 mm, while the left
> part is set to 0.2 mm. If you press any of these sizes to change one of
> them, the other one follows, just like it should. The initial values of 0.2
> and 0.3 are incoherent as they do not meet the basic idea of synchronizing
> the ends (which is checked by default).

I can't reproduce that, when I increase the left arrow from 0.2 to 0.3, even with the synchronize check case activated, the right arrow doesn't change unless the two have the same value, and then are synchronized. 
> 
> Also bad: if you just draw a simple arrow and edit the properties, you can
> see that the "synchronize ends" is checked, although it is obvious that the
> arrow does not have synchronized ends (the left end has a line, the right
> end an arrow). And indeed the sizes are set to 0.2 and 0.3.

Confirmed that the "synchronize ends" is checked even if one end is missing. 
So to resume: the two arrow heads should have the same default size and not synchonized by default is there is only one head. 
Set to new - Sophie
Comment 2 QA Administrators 2015-04-19 03:22:07 UTC Comment hidden (obsolete)
Comment 3 Jérôme Borme 2015-04-20 08:44:07 UTC 
(as per request) Still happens with version 4.4.1.2
Comment 4 QA Administrators 2016-09-20 09:32:22 UTC Comment hidden (obsolete)
Comment 5 QA Administrators 2021-08-12 03:57:34 UTC Comment hidden (obsolete)
Comment 6 Jérôme Borme 2021-08-15 22:39:04 UTC 
Still happens with 7.2.0.3 Community (gentoo/pg_overlay)

Possibly related to template.

I followed the steps using Firestbird template and it did not happen. When following step 3, the two size s were set to a value of 0.28 mm and the two ends of the arrow appeared the same on-screen.

Followed same with the Focus template and the bug happened (same by choosing no template). Drawing a left-to-right arrow, the Edit Style let me choose the left-end marker, both appeaed to be at 0.2 mm (their default value in this template), but after pressing ok it is clear the the left and right markers have different sizes. Using right-click/Line properties on the arrow then shows that the right marker is 0.3 mm in size, which is different from what appeared to have been set in the first step.

Also, the "Synchronise ends" check box is misleading. When ticking it, it does not synchronise the ends. It does nothing by itself. If pressing ok and then editing line properties again, it does not even stay ticked. What it does, is if it is ticked AND THEN the user changes some property, then both are changed the same way. Keeping its functionality, it could be better named "Synchronise changes [on both ends]".
Comment 7 sdc.blanco 2022-04-12 10:29:53 UTC 
(In reply to Jérôme Borme from comment #6)
> Also, the "Synchronise ends" check box is misleading. ... it could be better
> named "Synchronise changes [on both ends]".

Let's ask Design Team -- might be an EasyHack
Comment 8 Heiko Tietze 2022-04-13 09:21:59 UTC 
Some issues here: 
1) the "Synchronize Ends" checkbox is misleading - a lock icon between the two controls would be better; or we disable one of the controls if synchronize is checked
2) checking synchronize has no immediate effect on the two endings, meaning 0.2 / 0.3 are still different unless one is changed - this might be solved by #1
3) setting an arrow via sidebar ends up with a different size - since synchronize is not active by default this is not wrong but inconvenient; we should use 0.3 cm by default

In a nutshell: move the checkbox between the controls and make it a toggle icon, adjust the values when synchronize is checked, and change the default at the sidebar.

Code pointers: cui/uiconfig/ui/linetabpage.ui and cui/source/tabpages/tpline.cxx for the dialog; the sidebar is a bit tricky to find, I'd start at .uno:LineEndStyle (called by the sidebar control) pointing to SID_ATTR_LINEEND_STYLE which might be related to SID_ATTRIBUTES_LINE.. but at this point I stopped digging the code. Maybe Hossein finds the place where these 0.2cm are defined.