Created attachment 90148 [details] xml which was dumped While creating a unit test for bug#71434, using the XML dump method, the xml file which the program created has duplicate attribute: "name" My master is built at http://cgit.freedesktop.org/libreoffice/core/commit/?id=62fcdfa34aa302aa9051e90e75b94eb442fa1db7 pptx file: attachment 88942 [details] xml file attached, see line 3, there are two instances of name="Picture 5", one near the start, another near the end of line.
Created attachment 90149 [details] patch, showing current situation :) the pptx file could be downloaded at >> attachment 88942 [details]
Created attachment 90150 [details] error log
I think the bug resides near here: http://opengrok.libreoffice.org/xref/core/drawinglayer/source/dumper/XShapeDumper.cxx#dumpXShape
The bug is we have dumped "name" attributes two times: First: http://opengrok.libreoffice.org/xref/core/drawinglayer/source/dumper/XShapeDumper.cxx#1820 Second: In dumpShapeService function: > 1859 if(xServiceInfo->supportsService("com.sun.star.drawing.Shape")) > 1860 dumpShapeService(xPropSet, xmlWriter);
Patch submitted to gerrit: https://gerrit.libreoffice.org/6984
Korrawit Pruegsanusak committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a78f683b1e53d1328af11abdcd362e93db837701 fdo#72260: guard against duplicate "name" attribute The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Fixed.