Bug Hunting Session
Bug 72850 - ODF export: header-left / footer-left elements have spurious style:display="false"
Summary: ODF export: header-left / footer-left elements have spurious style:display="f...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: filters and storage (show other bugs)
Version:
(earliest affected)
4.0.0.0.beta1
Hardware: Other All
: medium normal
Assignee: Michael Stahl (CIB)
URL:
Whiteboard: odf target:4.2.0.2 target:4.1.5
Keywords: regression
Depends on:
Blocks:
 
Reported: 2013-12-18 22:30 UTC by Michael Stahl (CIB)
Modified: 2013-12-19 16:55 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Stahl (CIB) 2013-12-18 22:30:28 UTC
header-left , header-first etc. elements have a spurious 
style:display="false" attribute in LO 4.0.x

because this commit removed an inversion from 4 booleans:

commit d92345561c998f7382cf9ef0fdcd29096f978435
Author:     Caolán McNamara <caolanm@redhat.com>
AuthorDate: Tue Oct 2 14:41:59 2012 +0100

    don't blow up on .odt export with !hasValue footers/headers


... good thing that there's no code anywhere to import that attribute :)
Comment 1 Commit Notification 2013-12-18 22:52:06 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8f73c7615ebe60ef71d6e8b49a0f19ddac6f03a0

fdo#72850: ODF export: don't export spurious style:display="false"



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 2 Commit Notification 2013-12-18 22:56:29 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-4-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8d00de2114f148857291aee9a5dc31e92597412d&h=libreoffice-4-2

fdo#72850: ODF export: don't export spurious style:display="false"


It will be available in LibreOffice 4.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2013-12-19 09:47:44 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-4-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=854866140bff2ae4c587c7adc9b3170f06135437&h=libreoffice-4-1

fdo#72850: ODF export: don't export spurious style:display="false"


It will be available in LibreOffice 4.1.5.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 4 Caolán McNamara 2013-12-19 16:55:31 UTC
oops, go me!