When a search reaches the end of the document (or the beginning, in the case of reverse search), a dialog pops up asking whether the user wants to continue searching at the beginning (or end) of the document. This is an unnecessary interruption and violates the "ux-interruption" principle. Rather than showing a modal dialog, the label "Reached the end of the document" should appear at the end of the Find bar, as in Firefox, or, better yet, there should be a persistent label showing the order of the result out of all the results (e.g. "13/24"), as in Chromium. The label should have a much lighter color than active buttons, to be clearly differentiated as non-actionable. Similarly, the "Search key not found." dialog is an unnecessary interruption and should be replaced with a label in the find bar as well. Operating System: All Version: 4.1.0.4 release
Nice idea! thanks - Cor
Absolutely useful suggestion. Chrome does this best, Firefox can also learn from that and copy some improvements. LO can also learn and improve search in a similar manner. Love that idea Mirek2.
Matuš Kukan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f25cdaa78d5e7d200fbaf31cce9895bab7c5ee63 fdo#74132: Do not interrupt search in Writer. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Matuš Kukan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d50e08b4e18ad6fa8b4078df6e23ffbaf47e708c fdo#74132: Do not interrupt search in Calc. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Ahum, Matúš, Mirek, Does the provisioned solution foresee in the situation where a search does not start at the beginning of a document, and that then from the end the searching automatically continues at the beginning? (That was in any case my understanding of the idea...) Thanks, Cor
(In reply to comment #5) > Ahum, Matúš, Mirek, > > Does the provisioned solution foresee in the situation where a search does > not start at the beginning of a document, and that then from the end the > searching automatically continues at the beginning? > > (That was in any case my understanding of the idea...) > > Thanks, > Cor Hi Cor, If I'm not mistaken, the feature works the same way as it used to, except instead of a modal dialog, you get a label. You can still search from the middle of the document.
*** Bug 77112 has been marked as a duplicate of this bug. ***
Jan Holesovsky committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=bc37514ed6b8694872d0e958428a940ca9835619 fdo#74132: Do not interrupt search in Impress and Draw. It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jan Holesovsky committed a patch related to this issue. It has been pushed to "libreoffice-5-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=948d606b0260a33a5db77061f560afebde3fcdb7&h=libreoffice-5-0 fdo#74132: Do not interrupt search in Impress and Draw. It will be available in 5.0.0.0.beta2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=8d1d280741f62d60fe56cd86da995b08228a1594 Related: tdf#74132 CppunitTest_sd_export_tests: clean up testSearch() It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.