Bug 74318 - 'customize toolbar' broken
Summary: 'customize toolbar' broken
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
4.3.0.0.alpha0+ Master
Hardware: Other All
: medium blocker
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: regression
: 74399 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-02-01 12:57 UTC by tommy27
Modified: 2014-02-03 05:23 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tommy27 2014-02-01 12:57:53 UTC
issue reported by a Windows user (VITRIOL) in the italian OOo/LibO newsgroup.
confirmed by me with 4.2.0.4 under Win7 64bit.

steps to reproduce:
1- open any LibO module
2- right click on any toolbar
3- select "customize" toolbar
4- flag any of the unchecked icons to make it visible
5- click OK

actually no change in toolbars is retained in 4.2.0.4, so toolbar customization is totally broken, this qualifies this as a MAB since it's a nasty regression breaking a basilar UI feature.

the same test performed with 4.3.0.0.alpha0+ * causes immediate crash after "5".

interestingly in 4.2.0.4 the toolbar doesn't show the new selected icon in "4" and even after "5" the icon is not visible, anyway no crash.

in 4.3.0.0.alpha0+ you see the icon showing up at "4" but you see immediate crash soon after.



* Build ID: c634faf12886228754eb59ec9bedf6cd6f631054
TinderBox: Win-x86@42, Branch:master, Time: 2014-01-29_22:45:18
Comment 1 tommy27 2014-02-01 13:05:13 UTC
as an additional
Comment 2 tommy27 2014-02-01 13:17:00 UTC
additional information: if I replace the 4.2.x user profile with my current 4.1.x profile, the customize feature works fine again
Comment 3 Jean-Baptiste Faure 2014-02-01 13:18:15 UTC
I do not reproduce with LO 4.2.1.0.0+ and 4.2.0.4 on Ubuntu 13.10 x86-64

I remember I have seen this problem several months ago but not anymore.

Did you check if you didn't save the toolbar modifications in the file instead in Writer ?

Best regards. JBF
Comment 4 tommy27 2014-02-01 13:46:09 UTC
if I enable advanced features (Tools/Options/Advanced/Enable experimental features) the toolbar customize works in 4.1.4.2.

this explains why my 4.1.x profile (where I had that features enabled) made it work.

then even after disabling that setting it keeps working.
Comment 5 Jorendc 2014-02-01 14:42:02 UTC
Fail to reproduce, tested using Mac OSX 10.9 with LibreOffice Version: 4.2.0.4 
Build ID: 05dceb5d363845f2cf968344d7adab8dcfb2ba71

Looks Windows only.
Comment 6 tommy27 2014-02-01 15:02:08 UTC
my 4.2.0.4 tests have been done on portable X-LibO version
http://www.winpenpack.com/main/download.php?view.1354

issue is reproducible on my Win7 64bit and WinXP 32bit computers and on VITRIOL's Win7 64bit computer.

my 4.3.0.0+ test has been done on a regular clean install of a recent daily build on a Win7 64bit machine, so this shows that the bug is not limited to the portable version

it seems the issue appears just when using a new clean user profile.
see Comment 2 and Comment 4

@JBF and Jorendc
try temporarily resetting your 4.2.0.4 profiles to see if you reproduce the issue.
previous settings inherited from 4.1.x could workaround the bug on your Linux and Mac machines.
Comment 7 Julien Nabet 2014-02-01 23:09:48 UTC
tommy27: would it be possible you retrieve an useful backtrace by using this?
(see https://wiki.documentfoundation.org/QA/BugReport/Debug_Information#Windows:_How_to_get_a_backtrace)

bfoman: thought you might be interested in this tracker
Comment 8 tommy27 2014-02-02 04:27:18 UTC
restested with regular 4.2.0.4 install version and toolbar customization works in both the Win7 and WinXP machine.... this make me think that the bug is just of the portable version (I will ping the guys at winPenPack.com about it)

installed a new 4.3.0.0.alpha * on Win7 64 bit and this time I see no crash.

so I'm marking this as RESOLVED WORKFORME
sorry for the noise
Comment 9 tommy27 2014-02-02 04:40:01 UTC
for the record

crash happened with:
Version: 4.3.0.0.alpha0+
Build ID: c634faf12886228754eb59ec9bedf6cd6f631054
TinderBox: Win-x86@42, Branch:master, Time: 2014-01-29_22:45:18

no crash with:
Version: 4.3.0.0.alpha0+
Build ID: a995462e6855061816c6529c366f20ace2b45868
TinderBox: Win-x86@42, Branch:master, Time: 2014-01-31_23:29:34
Comment 10 tommy27 2014-02-02 20:34:45 UTC
*** Bug 74399 has been marked as a duplicate of this bug. ***
Comment 11 tommy27 2014-02-02 21:03:33 UTC
after some inquiries I found that the issue that me and VITRIOL encountered in the 4.2.0 version was a bug of the winPenPack portable package.

the guys at wPP have already a fix for those using that release:
http://www.winpenpack.com/main/e107_plugins/forum/forum_viewtopic.php?58170.last


anyway I confirm the coincidence of a very similar issue (even worst, with a crash) using recent 4.3.0.0.alpha+ daily builds, both on Windows (see Comment 0) and Mac OS (see Bug 74399)

anyway, as said in Comment 9, a newer daily build seems not affected anymore.

because of this I remove it from the mab4.2 list and I change platform to ALL:
Comment 12 Kohei Yoshida 2014-02-03 05:23:29 UTC
See Bug 74252 regarding the master build.