vcl/source/gdi/bitmap3.cxx uses an awful coding style. The following commits which improved Bitmap::ImplScaleSuper should be used as guidelines. http://cgit.freedesktop.org/libreoffice/core/commit/?id=abfe6e9866774aced6fac97e65415fa90107ad9b http://cgit.freedesktop.org/libreoffice/core/commit/?id=38f9952a7d7f622b22dad653a174c885ad91f1a7 http://cgit.freedesktop.org/libreoffice/core/commit/?id=38f9952a7d7f622b22dad653a174c885ad91f1a7 http://cgit.freedesktop.org/libreoffice/core/commit/?id=59253eb3193b9d175a906a6cbe9b870509ef8644 http://cgit.freedesktop.org/libreoffice/core/commit/?id=2da8bfe2da964cd43e1c709890fddd3c05dcecd1 http://cgit.freedesktop.org/libreoffice/core/commit/?id=cfe7e9d06f24c8d3b758e996455c5787771a5a45 http://cgit.freedesktop.org/libreoffice/core/commit/?id=fa395e689e22d6bc49785bdf688057546ea27f62 http://cgit.freedesktop.org/libreoffice/core/commit/?id=28038998856e8c61f018b985452bbff13aa5c6e6 http://cgit.freedesktop.org/libreoffice/core/commit/?id=26be573655133ef2db6e83f1b163854f4ee22c76 http://cgit.freedesktop.org/libreoffice/core/commit/?id=e6de01365989667a693546a0786f10c81ccef85c http://cgit.freedesktop.org/libreoffice/core/commit/?id=3234001d3fada2e4ba9ed890ffac548eba389f5a There are a number of functions in this file that would benefit from similar changes.
Making it an easy hack
Hello, I am willing to work on this "bug". I was wondering if it is ok to submit the WHOLE file with it's diff, or should I submit chunks of about 100 lines each?
(In reply to comment #2) > Hello, I am willing to work on this "bug". I was wondering if it is ok to > submit the WHOLE file with it's diff, or should I submit chunks of about 100 > lines each? Please submit a git format-patch or use gerrit.libreoffice.org directly.
Hi. I would like to start working on this issue as a part of my assignment at school. The subject is called Open-Source programming. However, I am not fully familiar with the open-source development yet therefore it might take a while before I am finished with my work. The deadline should be at most in 10 weeks, however, I believe I will be done with the work sooner. I hope this delay will not be much of an issue and you will allow me to take my time. Thank you :-)
Milan: Great to see you interested in this task! Blocking it is not completely ideal though; so if somebody fixes it before you get to that, you will have to pick another one :-) Having said that, blocking in horizon of days is fine of course - so let us know when you are finished with the LibreOffice build and start the work for real. Until then, it should be still free for others I am afraid - hope it is fine for you! Should you have further questions, feel free to mail me directly - you can do so in Czech ;-)
Thank you for the warm welcome :) If somebody takes it it will be sad and unfortunate, but I will probably be able to deal with it :) However if nobody takes it I could start working on it soon since I already have built LO on my computer and I just need to find some free time among my other subjects. I'll keep you posted.
Milan Zelenka committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=95d7ebd22dd20da5a7a26000494b553944fc23ee Improved coding style as shown in examples fdo#75240 The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I assume we can set this EasyHack to Resolved and Fixed?
Migrating Whiteboard tags to Keywords: (EasyHack DifficultyBeginner SkillCpp TopicCleanup) [NinjaEdit]
Remove LibreOffice Dev List from CC on EasyHacks (curtailing excessive email to list) [NinjaEdit]