Bug 75341 - UI: No Error-Dialog appears, when Input is set to required in a Field of a Form, but not set in the Table
Summary: UI: No Error-Dialog appears, when Input is set to required in a Field of a Fo...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: Other All
: medium normal
Assignee: Julien Nabet
URL:
Whiteboard: target:6.2.0 target:6.1.2
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-21 20:56 UTC by robert
Modified: 2018-09-07 10:01 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description robert 2014-02-21 20:56:28 UTC
In a form you could chose for every field the property "Input required". This property doesn't do anything if there isn't set "Input required" also in the table, which should be filled by the form.

Expected behavior: You could chose "Input required" in a field of a form and the dialog of an error occurs, if there is missing input. This error should appear, if there is "Input required" set in the form or set in the table (through SQL) or in both ways - but it isn't shown only, when it is set in both ways.

See https://bugs.freedesktop.org/attachment.cgi?id=94532 for an example. Open the form "Table_Input_requred_GUI". You could save data without any content except the primarykey "ID". But all fields were set to "Input required" in the GUI of the form.
Comment 1 Buovjaga 2014-11-08 14:32:23 UTC
Reproduced. All the columns have Input required: Yes, but it still allows to save without content.

Win 7 64-bit Version: 4.4.0.0.alpha2+
Build ID: c989f5e0e11e295b11ffc921b0d105869e037e47
TinderBox: Win-x86@42, Branch:master, Time: 2014-11-07_22:50:48
Comment 2 Alex Thurgood 2015-01-03 17:39:34 UTC Comment hidden (no-value)
Comment 3 QA Administrators 2017-05-22 13:20:08 UTC Comment hidden (obsolete)
Comment 4 robert 2017-05-28 17:30:50 UTC
Bug still exists with LO 5.4.0.0.beta1, OpenSUSE 42.1 Leap, 64bit rpm Linux.
Comment 5 QA Administrators 2018-05-29 02:36:57 UTC Comment hidden (obsolete)
Comment 6 robert 2018-05-29 05:42:02 UTC
Bug still exists with LO 6.0.4.2, OpenSUSE 42.3 Leap, 64bit rpm Linux.
Comment 7 Julien Nabet 2018-09-06 07:36:40 UTC
I think it could be interesting to test this again following tdf#91837 fix.
I'll give it a try.
Comment 8 Julien Nabet 2018-09-06 17:51:51 UTC
(In reply to Julien Nabet from comment #7)
> I think it could be interesting to test this again following tdf#91837 fix.
> I'll give it a try.

I could still reproduce this
Comment 9 Julien Nabet 2018-09-06 19:01:49 UTC
I gave a try with https://gerrit.libreoffice.org/#/c/60109/
Comment 10 Commit Notification 2018-09-07 05:02:17 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=dbb444e4ed7c19a11733ce8438bbb6546d42f852

tdf#75341: fix condition to approve row (form)

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Julien Nabet 2018-09-07 06:48:46 UTC
Backports in gerrit waiting for review
6.1: https://gerrit.libreoffice.org/#/c/60125/
6.0: https://gerrit.libreoffice.org/#/c/60126/
Comment 12 Julien Nabet 2018-09-07 08:38:45 UTC
Just for information, since analyzing consequences of the patch on 6.0 may take some time and 6.0 branch will be soon EOL , the fix won't be backport on it.
Comment 13 Commit Notification 2018-09-07 10:01:14 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-6-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=3448ca93eb46365d05387f7f3512c706bdb987c4&h=libreoffice-6-1

tdf#75341: fix condition to approve row (form)

It will be available in 6.1.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.