Bug 76005 - UI missing to set document properties: "TabsRelativeToIndent", "TabOverMargin"
Summary: UI missing to set document properties: "TabsRelativeToIndent", "TabOverMargin"
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.2.1.1 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:24.8.0
Keywords: difficultyInteresting, easyHack, skillCpp
: 75159 (view as bug list)
Depends on:
Blocks: Options-Dialog-Writer
  Show dependency treegraph
 
Reported: 2014-03-10 22:14 UTC by d33tah
Modified: 2024-04-25 05:46 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
A test case. (deleted)
2014-03-10 22:14 UTC, d33tah
Details

Note You need to log in before you can comment on or make changes to this bug.
Description d33tah 2014-03-10 22:14:00 UTC
Created attachment 95561 [details]
A test case.

I really tried to RTFM and asked people on IRC for help, but couldn't figure it out. 

In the attached testcase, I used a table that originally belonged to some template downloaded from the internet (possibly originally in .DOC format). In this table I wanted to align the text to a tabulator, but any attempts to do that resulted in the text being pushed far too right when I pressed ctr+tab.
Comment 1 Mike Kaganski 2014-03-11 12:10:43 UTC
In your file, the "settings.xml" contains setting named "TabsRelativeToIndent", which is set to false. If set to true, everything works OK.
Note that it works OK with your settings, too, but not in the way you expect it. This setting tells that you see all tab positions relative to left page margin, not to the cell that you work in. And the program does just this, thus working correctly with regards to developer's intent.

The problem is how would you change this document setting without manual modifications of the document internals...

I suppose that this bug at most can be qualified as an enhancement request to add a UI to allow this setting be modified. And possibly, others too.
However, I keep the "medium" priority, because it is not a low-priority problem: without such a control, this would be a problem for people having different documents behaving differently, without a way to make them work consistently.
Comment 2 Joe Rayhawk 2014-03-12 00:40:56 UTC
The content of attachment 95561 [details] has been deleted by
    Joe Rayhawk <jrayhawk+bugs.freedesktop.org@omgwallhack.org>
who provided the following reason:

Private information disclosure.

The token used to delete this attachment was generated at 2014-03-12 00:40:45 UTC.
Comment 3 Heiko Tietze 2019-08-31 06:14:42 UTC Comment hidden (off-topic)
Comment 4 Mike Kaganski 2020-07-10 07:22:24 UTC Comment hidden (off-topic)
Comment 5 Heiko Tietze 2020-07-10 10:03:58 UTC Comment hidden (obsolete)
Comment 6 Mike Kaganski 2020-07-10 10:06:03 UTC
(In reply to Heiko Tietze from comment #5)

No, it is a compatibility option, and must go to the relevant options list. Which is on Options->Writer->Compatibility (the "for document" section).
Comment 7 Heiko Tietze 2020-07-10 10:18:08 UTC
(In reply to Mike Kaganski from comment #6)
> (In reply to Heiko Tietze from comment #5)
> 
> No, it is a compatibility option, and must go to the relevant options list.
> Which is on Options->Writer->Compatibility (the "for document" section).

Could be an easyhack then. Could you add code pointers please?
Comment 8 Mike Kaganski 2020-08-04 08:11:09 UTC
Another missing compatibility property: "TabOverMargin", which must be added there in the same way.
Comment 9 Timur 2022-09-09 08:29:28 UTC
*** Bug 75159 has been marked as a duplicate of this bug. ***
Comment 10 Mike Kaganski 2024-01-27 05:13:22 UTC
A commit that adds adds another compatibility option to the dialog:
https://gerrit.libreoffice.org/c/core/+/162635
Comment 11 Aron Budea 2024-02-05 06:18:56 UTC
For reference, compatibility flag TabsRelativeToIndent was added in the following commits to fix this bug:
https://bz.apache.org/ooo/show_bug.cgi?id=24363

https://cgit.freedesktop.org/libreoffice/core/commit/?id=009e3f4841378f13a2764a2c84e147e401b70525
author		Oliver Bolte <obo@openoffice.org>	2008-01-10 10:37:10 +0000
committer	Oliver Bolte <obo@openoffice.org>	2008-01-10 10:37:10 +0000

"INTEGRATION: CWS xmlfilter02 (1.61.12); FILE MERGED"

https://cgit.freedesktop.org/libreoffice/core/commit/?id=0b35fd0181bf21ee4686b9488b8ab10b3f28e89e
author		Oliver Bolte <obo@openoffice.org>	2008-01-10 10:40:55 +0000
committer	Oliver Bolte <obo@openoffice.org>	2008-01-10 10:40:55 +0000

"INTEGRATION: CWS xmlfilter02 (1.26.12); FILE MERGED"

Compatibility flag TabOverMargin was added here:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=bdfc6363d66aa079512cc8008996b633f693fed1
author		Miklos Vajna <vmiklos@suse.cz>	2013-01-08 11:57:13 +0100
committer	Miklos Vajna <vmiklos@suse.cz>	2013-01-08 14:17:27 +0100

n#793998 sw: add TabOverMargin compat mode
Comment 12 Mohit Marathe 2024-04-16 17:46:37 UTC
I'm currently working on this. You can find my patch (work in progress) here: https://gerrit.libreoffice.org/c/core/+/166040.

I'm not sure which flags to invalidate in `sw/source/core/view/viewsh.cxx`.

Can anyone provide some pointers?
Comment 13 Heiko Tietze 2024-04-17 09:08:11 UTC
(In reply to Mohit Marathe from comment #12)
> Can anyone provide some pointers?
Hossein, can you?
Comment 14 Mike Kaganski 2024-04-17 10:12:05 UTC
(In reply to Heiko Tietze from comment #13)

I answered in the gerrit change. IMO, just invalidating all makes sense in this case.
Comment 15 Commit Notification 2024-04-25 05:46:52 UTC
Mohit Marathe committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b51271b85387a57b4cdd20ee6277c1a955706fc1

tdf#76005 add TabsRelativeToIndent, TabOverMargin compat option to dialog

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.