The calc unit tests pre-date the pretty new string constructors, so we have lots of this sort of thing:
Where the 'OUString()' is not needed - and should be removed in favour of a plain "Sheet1".
Similarly we have a number of:
Where there is no need for a local variable; we can axe the OUString line and pass "TestTab" directly in many cases.
Ah - and the code path is sc/qa/unit/ucalc.cxx =)
I will take this bug - changed the assigned to
I have already completed the patch for the bug. Will put it onboard in few hours
Bug fixed. Mail sent to mailing list with patch :)
Thanks; pushed to master ! =)
Manas Joshi committed a patch related to this issue.
It has been pushed to "master":
fdo#76181 - cleanup OUString constructors
The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.
Migrating Whiteboard tags to Keywords: (EasyHack DifficultyBeginner SkillCpp TopicCleanup )