Created attachment 99892 [details] File with data In the attached file I want to perform a statistics type "correlation". If I use Data > Statistics > Correlation LO crashes. It makes no difference whether I have previously selected range C1:G11 or C2:G11 or have nothing selected. I get the crash with Version: 4.4.0.0.alpha0+ Build ID: aa453de65b8b44f9c1e6012caaeef11df9ff65fc TinderBox: Win-x86@39, Branch:master, Time: 2014-05-24_13:45:34 but there is no crash with Version: 4.3.0.0.alpha1+ Build ID: 0b03f7ed575838f90e6b1ebec3538a3a214f81fb TinderBox: Win-x86@39, Branch:master, Time: 2014-04-30_01:30:46
Created attachment 99893 [details] Screenshot of the error message
Reproducible: Win7x64 Version: 4.4.0.0.alpha0+ Build ID: dc91ebed1a3b0ef900b1bb5cf203c6a9aeb83016 TinderBox: Win-x86@39, Branch:master, Time: 2014-05-26_01:36:09 Selecting twice "Ignore" Libreoffice continues running. Windbg " Assertion failed! Program: ...XXXX\Downloads\LibreOfficeMaster\program\vcllo.dll File: C:/cygwin/home/tinderbox/master/vcl/sourc.../builder.cxx Line: 2978 Expression: false For information on how your program can cause an assertion failure, see the Visual C++ documentation on asserts (Press Retry to debug the application - JIT must be enabled)Assertion failed! Program: ...XXXX\Downloads\LibreOfficeMaster\program\vcllo.dll File: C:/cygwin/home/tinderbox/master/vcl/sourc.../builder.cxx Line: 2978 Expression: false For information on how your program can cause an assertion failure, see the Visual C++ documentation on asserts (Press Retry to debug the application - JIT must be enabled) "
On pc Debian x86-64 with master sources updated today, I could reproduce this. It seems that every entry of stats (at least first four) make LO crash. I could reproduce the crash with 4.3 sources updated 1 week ago but not with 4.2 sources updated some days ago.
Created attachment 103552 [details] bt with master sources I attached simple and full bts with master sources.
I'm working on it.
Julien Nabet committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=cb3dcb0b2ec1a7ecacb72ec1348010000163aa06 Resolves fdo#79273: Data Statistics crashes with any entry The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Good catch once again. I'll backport this to 4.3.
Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-4-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c5ed29a621396de4fff5e9fa7b61b7303295edc9&h=libreoffice-4-3 Resolves fdo#79273: Data Statistics crashes with any entry It will be available in LibreOffice 4.3.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thank you Kohei for the review, I'll put it fixed now.
Caolan: the patch (http://cgit.freedesktop.org/libreoffice/core/commit/?id=cb3dcb0b2ec1a7ecacb72ec1348010000163aa06) pushed works but I made more tests and saw that adding again "cancel" action-widget was ok. Should I add again cancel for all the ui files I changed? (How can it work without "cancel" action-widget?)
caolanm->julien: We are only currently using the "responses" for message dialogs, i.e. we look up the button pressed and return the response id for that as the dialog return value. For all the other dialogs we aren't using responses yet which is why things work with the missing action-widget lines. Ideally cancel should be listed there when there is a cancel button in the dialog, but its super low priority as the functionality isn't in use for those types of dialogs.
Thank you Caolan for the feedback. So I'll let this as it is now.