Download it now!
Bug 79506 - Some numbers are marked as translatable
Summary: Some numbers are marked as translatable
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Localization (show other bugs)
Version:
(earliest affected)
4.3.0.0.beta1
Hardware: All All
: low minor
Assignee: Julien Nabet
URL:
Whiteboard: target:4.4.0 target:4.3.0.0.beta2
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-01 14:23 UTC by Stanislav Horacek
Modified: 2014-06-02 08:36 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
unnecessary numbers in po files (3.35 KB, text/plain)
2014-06-01 14:23 UTC, Stanislav Horacek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stanislav Horacek 2014-06-01 14:23:01 UTC
Created attachment 100237 [details]
unnecessary numbers in po files

In the files defining user interface, there are some numbers that are incorrectly marked as translatable. Therefore these strings appear unnecessary in .po files for translation.

The list of these strings copied from .po files is attached.
Comment 1 Julien Nabet 2014-06-01 16:31:10 UTC
I Opengroked some examples given and indeed they're translatable.

Andras: may I remove "<translatable="yes">" for these?
Comment 2 Andras Timar 2014-06-01 16:49:44 UTC
(In reply to comment #1)
> I Opengroked some examples given and indeed they're translatable.
> 
> Andras: may I remove "<translatable="yes">" for these?

Yes, or even better, change them to translatable="no". Thanks.
Comment 3 Julien Nabet 2014-06-01 17:58:55 UTC
Thank you Andras for your feedback, I'll take this one.
Comment 4 Julien Nabet 2014-06-01 18:38:58 UTC
Andras: by doing the changes I wonder 2 things:
1) May strings containing decimal would need to be translatable because some countries use "." for decimal and other "," for example?

2) Are there countries which use other format for numbers? (Asiatic languages or others perhaps?)
Comment 5 Andras Timar 2014-06-01 19:08:01 UTC
Julien: Number format depends on the locale setting, not on the UI language. Therefore it is not good to have these numbers marked as translatable. Moreover, actual numbers should come from the config, not from the .ui files. So I think these hardwired defaults in .ui files are ignored anyway.
Comment 6 Julien Nabet 2014-06-01 20:05:40 UTC
ok, I made the changes.

What about this last one? (See http://opengrok.libreoffice.org/xref/core/sd/source/ui/view/DocumentRenderer.src#55)

     55     StringArray _STR_IMPRESS_PRINT_UI_SLIDESPERPAGE_CHOICES
     56     {
     57         ItemList [ en-US ] =
     58         {
     59             < "Default" ; > ;
     60             < "1" ; > ;
     61             < "2" ; > ;
     62             < "3" ; > ;
     63             < "4" ; > ;
     64             < "6" ; > ;
     65             < "9" ; > ;
     66         };
     67     };

Since there's "Default" in ItemList, I suppose we can't just remove "[ en-US ]"?
Comment 7 Andras Timar 2014-06-01 20:22:51 UTC
(In reply to comment #6)

> Since there's "Default" in ItemList, I suppose we can't just remove "[ en-US
> ]"?

Yes, this is an exception. Maybe it is not worth the effort to rewrite GetSlidesPerPageSequence() at http://opengrok.libreoffice.org/xref/core/sd/source/ui/view/DocumentRenderer.cxx#651
Comment 8 Commit Notification 2014-06-01 20:35:36 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=acdff9f9763847c992e0853022896cff781c5ffe

Resolves: fdo#79506 Some numbers are marked as translatable



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2014-06-02 08:35:24 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-4-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=791f129273dfabce4989cf6607db625104d28571&h=libreoffice-4-3

Resolves: fdo#79506 Some numbers are marked as translatable


It will be available in LibreOffice 4.3.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.