Created attachment 100237 [details] unnecessary numbers in po files In the files defining user interface, there are some numbers that are incorrectly marked as translatable. Therefore these strings appear unnecessary in .po files for translation. The list of these strings copied from .po files is attached.
I Opengroked some examples given and indeed they're translatable. Andras: may I remove "<translatable="yes">" for these?
(In reply to comment #1) > I Opengroked some examples given and indeed they're translatable. > > Andras: may I remove "<translatable="yes">" for these? Yes, or even better, change them to translatable="no". Thanks.
Thank you Andras for your feedback, I'll take this one.
Andras: by doing the changes I wonder 2 things: 1) May strings containing decimal would need to be translatable because some countries use "." for decimal and other "," for example? 2) Are there countries which use other format for numbers? (Asiatic languages or others perhaps?)
Julien: Number format depends on the locale setting, not on the UI language. Therefore it is not good to have these numbers marked as translatable. Moreover, actual numbers should come from the config, not from the .ui files. So I think these hardwired defaults in .ui files are ignored anyway.
ok, I made the changes. What about this last one? (See http://opengrok.libreoffice.org/xref/core/sd/source/ui/view/DocumentRenderer.src#55) 55 StringArray _STR_IMPRESS_PRINT_UI_SLIDESPERPAGE_CHOICES 56 { 57 ItemList [ en-US ] = 58 { 59 < "Default" ; > ; 60 < "1" ; > ; 61 < "2" ; > ; 62 < "3" ; > ; 63 < "4" ; > ; 64 < "6" ; > ; 65 < "9" ; > ; 66 }; 67 }; Since there's "Default" in ItemList, I suppose we can't just remove "[ en-US ]"?
(In reply to comment #6) > Since there's "Default" in ItemList, I suppose we can't just remove "[ en-US > ]"? Yes, this is an exception. Maybe it is not worth the effort to rewrite GetSlidesPerPageSequence() at http://opengrok.libreoffice.org/xref/core/sd/source/ui/view/DocumentRenderer.cxx#651
Julien Nabet committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=acdff9f9763847c992e0853022896cff781c5ffe Resolves: fdo#79506 Some numbers are marked as translatable The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-4-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=791f129273dfabce4989cf6607db625104d28571&h=libreoffice-4-3 Resolves: fdo#79506 Some numbers are marked as translatable It will be available in LibreOffice 4.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.