Bug 79739 - FILEOPEN: MSO ODT - Images appearing without adjusted brightness
Summary: FILEOPEN: MSO ODT - Images appearing without adjusted brightness
Status: RESOLVED NOTOURBUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: Other All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Writer-Images
  Show dependency treegraph
 
Reported: 2014-06-06 18:53 UTC by Yousuf Philips (jay) (retired)
Modified: 2020-09-30 18:11 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
4.1.6.2 export (1.66 MB, application/pdf)
2014-06-06 19:25 UTC, Firas Hanife
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2014-06-06 18:53:33 UTC
When examining attachment 93106 [details] from bug 74262, i noticed that most images in the document had a darkenness appearing above it in Word 2013. Tested on Linux Mint with LibO 3.6.7, 4.2.4 and 4.3 beta.

Example - attachment 100264 [details]
PDF export from MS Word 2013 - attachment 100262 [details]
Comment 1 Yousuf Philips (jay) (retired) 2014-06-06 19:01:44 UTC
Basically word 2013 has the image set to brightness -50%, but this is not understood by LibO or even Word 2010.
Comment 2 Firas Hanife 2014-06-06 19:24:07 UTC
Reproduced with 4.1.6.2.
Attached PDF export.

Changing Status to NEW.
Comment 3 Firas Hanife 2014-06-06 19:25:18 UTC
Created attachment 100528 [details]
4.1.6.2 export
Comment 4 QA Administrators 2015-06-08 14:41:37 UTC Comment hidden (obsolete)
Comment 5 Buovjaga 2015-08-02 09:42:46 UTC
Darkening still not applied.

Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+
Build ID: 902255645328efde34ddf62227c8278e8dd61ff0
TinderBox: Win-x86@39, Branch:master, Time: 2015-07-30_03:52:07
Locale: en-US (fi_FI)
Comment 6 QA Administrators 2016-09-20 10:20:51 UTC Comment hidden (obsolete)
Comment 7 Yousuf Philips (jay) (retired) 2017-10-08 13:04:29 UTC
A trimmed sample can be found here - attachment 136830 [details].

Tried WebODF, TextMaker and Calligra and they also dont show the adjusted brightness.

So i checked the difference in XML of a 0% brightness to the current -50% and the difference was that with 0% brightness set in word 2013, draw:luminance and draw:contrast attributes were removed.

<style:style ... style:name="a1" ...>
  <style:graphic-properties ... draw:luminance="0%" draw:contrast="0%" ... />
</style:style>

@Regina: Any thoughts?
Comment 8 Regina Henschel 2017-10-08 15:21:16 UTC
The topic of this issue is not clear to me: What have you done step by step, what do you expect to get, what do you actually get?

But nevertheless some "thoughts".
There are issues open in ODF regards luminance.
https://issues.oasis-open.org/browse/OFFICE-3821
https://issues.oasis-open.org/browse/OFFICE-3833

In ODF luminance is a non-destructive filter. The image in the file is not changed by the UI setting, only the information about the setting is stored. The user can change the tone adjustments and will always have the original image inside the document package.

In Word tone adjustment is applied to the image. So the user cannot go back to the original image. Because the tone adjustment is already applied, a draw:luminance attribute is not needed, when Word exports to odt.

The draw:luminance domain is -100% to +100% with 0% meaning no change. So a draw:luminance=0% needs only to be written, if you want to prevent inheritance from a parent style.
Comment 9 Yousuf Philips (jay) (retired) 2017-10-13 01:23:18 UTC
(In reply to Regina Henschel from comment #8)
> The topic of this issue is not clear to me: What have you done step by step,

steps:
1. open attachment 136830 [details] in word 2013 and LO
2. word 2013 has the images as -50% brightness and LO doesnt

> what do you expect to get

i expect that LO also has it as -50% brightness

> what do you actually get?

LO has it with 0% brightness
Comment 11 Regina Henschel 2017-10-15 16:50:38 UTC
Perhaps Word developers get confused because https://issues.oasis-open.org/browse/OFFICE-3821.
Comment 12 QA Administrators 2018-11-01 03:52:14 UTC Comment hidden (obsolete)
Comment 13 Buovjaga 2020-09-30 18:11:01 UTC
(In reply to Regina Henschel from comment #10)
> In Word 2010 I get 0% in a scale from -100% to 100%.
> 
> In the file itself it is draw:luminance="0%".
> 
> So for me it is an error in Word 2013.
> https://answers.microsoft.com/en-us/office/forum/office_2013_release-word/
> opendocument-opened-with-word-2013-image-inserted/9adbd2ec-87ae-4847-b343-
> 9005d6427516
> https://answers.microsoft.com/en-us/msoffice/forum/msoffice_word-
> mso_windows8/dark-pictures-in-odt-document-from-libreoffice/ab51fba6-f612-
> 455f-8a1a-a050d4e0fe7f

Then let's close