Download it now!
Bug 79851 - Remove deprecated SvStream load/save methods from SfxItemPool etc. ...
Summary: Remove deprecated SvStream load/save methods from SfxItemPool etc. ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: Other All
: medium enhancement
Assignee: Varun Dhall
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-09 20:44 UTC by Michael Meeks
Modified: 2018-03-05 09:29 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
patch hacking out legacy stuff. (19.48 KB, patch)
2014-06-09 20:44 UTC, Michael Meeks
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Meeks 2014-06-09 20:44:13 UTC
Created attachment 100769 [details]
patch hacking out legacy stuff.

This patch removes the SfxItemPool Load/Save - to SvStream - which gums up our code with a number of rather odd binary file format residue pieces.

Nominally these are used for EditEng copy/paste - but - strangely, when compiled without them copying shapes from draw to/from another draw with style attributes etc. appears to work just fine. Unclear what's going on.

A bit of surgery / debugging is needed in:

ImpEditEngine::CreateTransferable

I suspect, and also OutlinerView::Read( SvStream& rInput and similar places where I've done a partial cut.

Nevertheless libreoffice compiles rather nicely with this, and (potentially) it frees us of some evil / old bloat.

Thoughts appreciated; I guess its rather easy to accelerate SfxItemPool without having to wrestle with this mess ...
Comment 1 Caolán McNamara 2014-06-10 08:19:38 UTC
The thing to check is copying the text from inside one text box to another, with rich text especially
Comment 2 Michael Meeks 2014-06-10 09:56:01 UTC
Ah - right; that fails as expected =) I get a completely empty text when pasted - even inside the same document; good.

Well worth switching to RTF/ODF for that (I guess) if we can remove all that evil guff around the place there.
Comment 3 QA Administrators 2015-07-18 17:44:37 UTC Comment hidden (obsolete)
Comment 4 Michael Stahl (CIB) 2015-07-18 20:59:14 UTC
yes that horrible code still exists, no it's not a regression

let's set this to "enhancement"
Comment 5 Michael Stahl (CIB) 2018-03-05 09:29:43 UTC
oh, there was a bug for this?... Varun removed that stuff in last year's GSoC!